NCC-28 changing schedule to run 3 times a week - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Neotoma DOI minting pipeline to run on a more frequent schedule (3x/week) and documents/parameterizes the schedule timezone so runs can stay aligned to a consistent local time across DST changes.
Changes:
- Updated the default EventBridge Scheduler cron from weekly Friday to Mon/Wed/Fri at midnight.
- Added a
ScheduleTimezoneCloudFormation parameter and wired it intoScheduleExpressionTimezone. - Refreshed README and GitHub Actions workflow text to reflect the new recurring schedule.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates schedule documentation and diagrams to reflect Mon/Wed/Fri runs. |
| infrastructure/doi-minter.yaml | Changes default schedule, introduces ScheduleTimezone, and uses it for ScheduleExpressionTimezone. |
| entrypoint.sh | Updates header comment to reflect historical (manual Friday) context. |
| .github/workflows/run-minting.yml | Adjusts workflow comments to refer to scheduled runs generally (not weekly). |
| .github/workflows/deploy.yml | Updates deploy input/help text and summary output wording for “recurring schedule”. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+388
to
+389
| `ScheduleExpression` defaults to `cron(0 0 ? * MON,WED,FRI *)`, read in the | ||
| `ScheduleTimezone` parameter which defaults to `Los Angeles`; ie midnight Pacific on Mondays, Wednesdays and Fridays. |
| `ScheduleExpression` defaults to `cron(0 0 ? * MON,WED,FRI *)`, read in the | ||
| `ScheduleTimezone` parameter which defaults to `Los Angeles`; ie midnight Pacific on Mondays, Wednesdays and Fridays. | ||
|
|
||
| Running three times a week shortens how long a new dataset waits for its DOI, keeping the 48 hours window for datasets to settle. |
| Properties: | ||
| Name: !Sub "neotoma-doi-minting-${Environment}" | ||
| Description: Weekly Neotoma DOI minting run. | ||
| Description: Neotoma DOI minting run (midnight, Mondays/Wednesdays/Fridays). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.