Develop - #236
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refreshes API integration test inputs across multiple v1.5 and v2.0 endpoints (IDs, query string parameters), adds basic tests for two dataset-related endpoints, and extends the aeDNA assays-by-dataset payload to include additional FAIRe project fields.
Changes:
- Updated many Chakram tests to use new IDs/query parameters for contacts, datasets, sites, spatial, taxa, publications, and apps endpoints.
- Added new tests for
/v2.0/data/datasets/{datasetid}/assaysand/v2.0/data/datasets/{datasetid}/projects(status 200 checks). - Extended
assaysbydataset.sqlto includesterilisemethod,negcont, andposcontin the assay JSON payload.
Reviewed changes
Copilot reviewed 37 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| v2.0/helpers/assays/assaysbydataset.sql | Adds additional assay JSON fields (FAIRe-related) to the assays-by-dataset payload. |
| test/v2.0-data-taxa-test.js | Updates query params used in taxa list test. |
| test/v2.0-data-speleothems-{collectionunitid}-test.js | Updates collection unit ID used in speleothems test. |
| test/v2.0-data-spatial-lakes-test.js | Updates spatial lakes query params (siteid/buffer). |
| test/v2.0-data-spatial-icesheet-test.js | Updates icesheet query param (age). |
| test/v2.0-data-spatial-faunal-test.js | Updates faunal query param (sciname). |
| test/v2.0-data-sites-test.js | Updates sites search query params (IDs/filters). |
| test/v2.0-data-sites-{siteid}-test.js | Updates site ID used in site-by-id test. |
| test/v2.0-data-sites-{siteid}-datasets_elc-test.js | Updates site ID used in site datasets_elc test. |
| test/v2.0-data-sites-{siteid}-contacts-test.js | Updates site ID used in site contacts test. |
| test/v2.0-data-publications-test.js | Updates publications query params (IDs/filters). |
| test/v2.0-data-publications-{publicationid}-test.js | Updates publication ID used in publication-by-id test. |
| test/v2.0-data-pollen-test.js | Updates pollen query params (IDs/filters). |
| test/v2.0-data-pollen-{id}-test.js | Updates pollen record ID used in pollen-by-id test. |
| test/v2.0-data-occurrences-test.js | Updates occurrences query params (IDs/filters). |
| test/v2.0-data-geopoliticalunits-test.js | Updates geopolitical units query params (rank/lower). |
| test/v2.0-data-geopoliticalunits-{gpid}-test.js | Updates GPID used in geopoliticalunit-by-id test. |
| test/v2.0-data-geopoliticalunits-{gpid}-sites-test.js | Updates GPID used in geopoliticalunit sites test. |
| test/v2.0-data-geopoliticalunits-{gpid}-datasets-test.js | Updates GPID used in geopoliticalunit datasets test. |
| test/v2.0-data-dbtables-test.js | Updates dbtables list query params (table/count). |
| test/v2.0-data-dbtables-{table}-test.js | Updates table path segment and count param in dbtables-by-table test. |
| test/v2.0-data-datasets-test.js | Updates datasets query params (IDs/filters). |
| test/v2.0-data-datasets-db-test.js | Updates datasets/db query param (database). |
| test/v2.0-data-datasets-{datasetid}-projects-test.js | Adds a basic 200-response test for dataset projects endpoint. |
| test/v2.0-data-datasets-{datasetid}-assays-test.js | Adds a basic 200-response test for dataset assays endpoint. |
| test/v2.0-data-datasets_elc-test.js | Updates datasets_elc query params (IDs/filters). |
| test/v2.0-data-contacts-test.js | Updates contacts query params (IDs/filters). |
| test/v2.0-data-contacts-{contactid}-test.js | Updates contact ID used in contact-by-id test. |
| test/v2.0-data-contacts-{contactid}-sites-test.js | Updates contact ID used in contact sites test. |
| test/v2.0-data-contacts-{contactid}-publications-test.js | Updates contact ID used in contact publications test. |
| test/v2.0-apps-taphonomysystems-test.js | Updates datasettypeid used in taphonomysystems test. |
| test/v2.0-apps-depenvt-test.js | Updates depenvt query params (siteid/datasetid/collectionunitid). |
| test/v2.0-apps-constdb-datasetuploads-test.js | Updates dbid used in constituent-db datasetuploads test. |
| test/v2.0-apps-constdb-datasets-test.js | Updates dbid used in constituent-db datasets test. |
| test/v2.0-apps-constdb-datasetages-test.js | Updates dbid used in constituent-db datasetages test. |
| test/v1.5-data-geopoliticalunits-{gpid}-test.js | Updates GPID used in v1.5 geopoliticalunit-by-id test. |
| test/v1.5-data-contacts-{contactid}-test.js | Updates contact ID used in v1.5 contact-by-id test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates a variety of test cases for several API endpoints, mainly by changing the test input parameters (such as IDs and query string values) and adding new endpoint test files. The changes ensure that the tests use current, relevant, or more representative data, and expand test coverage for dataset-related endpoints.
Test Coverage Expansion:
/v2.0/data/datasets/{datasetid}/assaysand/v2.0/data/datasets/{datasetid}/projects, each with a test to verify a 200 response for a sample dataset. [1] [2]Test Parameter Updates:
test/v2.0-data-contacts-test.js,test/v2.0-data-datasets-test.js,test/v2.0-data-geopoliticalunits-test.js, and others. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]These updates help ensure the tests are aligned with the current state of the data and API, and improve the reliability and relevance of the test suite.