Skip to content

fix: decode URI-encoded local link paths #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyhrc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: decode URI-encoded local link paths #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/composables/useLinkRewriter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,20 @@ function isExternal(url: string): boolean {
return /^(https?:|data:|blob:|mailto:|tel:|asset:|tauri:)/i.test(url);
}

/** Decode URI escaping added by MarkdownIt before using a local URL as a file path. */
function resolveLocalPath(baseDir: string, urlPath: string): string {
let path = urlPath;
try {
path = decodeURIComponent(urlPath);
} catch {
// Raw HTML may contain a stray "%". Keep it unchanged instead of breaking
// every link rewrite in the rendered document.
}
return isAbsoluteWin(path) || isAbsoluteUnix(path)
? path
: joinPath(baseDir, path);
}

export interface RewriteContext {
currentFile: string;
rootDir: string;
Expand All @@ -55,8 +69,7 @@ export function rewriteImagesAndLinks(
const src = img.getAttribute("src") || "";
if (!src || isExternal(src)) return;
try {
const abs =
isAbsoluteWin(src) || isAbsoluteUnix(src) ? src : joinPath(baseDir, src);
const abs = resolveLocalPath(baseDir, src);
img.src = convertFileSrc(abs);
} catch {
/* skip */
Expand Down Expand Up @@ -86,11 +99,8 @@ export function rewriteImagesAndLinks(
const pathPart = hashIdx >= 0 ? href.slice(0, hashIdx) : href;
const hash = hashIdx >= 0 ? href.slice(hashIdx + 1) : "";
if (!pathPart) return;
if (!/\.(md|markdown|mdx|txt)$/i.test(pathPart)) return;
const abs =
isAbsoluteWin(pathPart) || isAbsoluteUnix(pathPart)
? pathPart
: joinPath(baseDir, pathPart);
const abs = resolveLocalPath(baseDir, pathPart);
if (!/\.(md|markdown|mdx|txt)$/i.test(abs)) return;
a.addEventListener("click", (e) => {
e.preventDefault();
onInternalLink(abs, hash);
Expand Down