Skip to content

fix(ci): handle seed containers that finish before the wait step - #1090

Merged
AchoArnold merged 1 commit into
mainfrom
fix/wait-for-completed-seed
Nov 17, 2026
Merged

AchoArnold merged 1 commit into
mainfrom
fix/wait-for-completed-seed

Conversation

@AchoArnold

Copy link
Copy Markdown
Member

Root cause

The failing runs stop in Seed Database, before tests or deployments. docker compose wait seed reports no containers for project "tests" when the fast seed container has already exited, although the container exists and its logs show successful inserts. Removing the old || true exposed this Compose race.

Fix

  • Resolve the seed container using docker compose ps --all --quiet seed, including stopped containers.
  • Wait on that explicit container ID with docker wait.
  • Check the returned container exit code explicitly so actual seed failures, missing containers, and Docker errors still fail CI rather than being ignored.

Verification

  • Reproduced the exact workflow step in Bash with Docker command fixtures: the original step fails only the already-completed-container case.
  • The fixed step passes all six cases: running, already completed, failed seed, missing container, lookup error, and wait error.
  • actionlint passed with only its outdated Ubuntu 26.04 runner-label warning filtered. YAML, Prettier, and whitespace checks passed.
  • GitHub Actions verification pending below.

Husky was skipped with explicit approval due to the existing lockfile release-age restriction. No dependency or policy changes.

Resolve the seed container including stopped containers, wait by its ID, and explicitly reject nonzero seed exit codes. This avoids docker compose wait incorrectly reporting no containers after fast seeding.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a0fd7292-f3aa-4919-929f-d73c2ac0f0c2
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

The workflow now finds the seed container even after it has stopped, then waits using its ID.

  • The CI job checks the seed container before running integration tests.

Reviews (1) · Last reviewed commit: "fix(ci): wait for seed containers that a..." · Reviewed by Greptile

@AchoArnold
AchoArnold merged commit 0ee2c7e into main Nov 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant