Repository navigation
fix(ci): handle seed containers that finish before the wait step - #1090
Merged
Merged
Conversation
Resolve the seed container including stopped containers, wait by its ID, and explicitly reject nonzero seed exit codes. This avoids docker compose wait incorrectly reporting no containers after fast seeding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a0fd7292-f3aa-4919-929f-d73c2ac0f0c2
Up to standards ✅🟢 Issues
|
Contributor
[Medium impact] This PR appears safe to merge. SummaryThe workflow now finds the seed container even after it has stopped, then waits using its ID.
Reviews (1) · Last reviewed commit: "fix(ci): wait for seed containers that a..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The failing runs stop in Seed Database, before tests or deployments.
docker compose wait seedreportsno containers for project "tests"when the fast seed container has already exited, although the container exists and its logs show successful inserts. Removing the old|| trueexposed this Compose race.Fix
docker compose ps --all --quiet seed, including stopped containers.docker wait.Verification
Husky was skipped with explicit approval due to the existing lockfile release-age restriction. No dependency or policy changes.