Skip to content

refactor(ci): split frontend deployments into explicit jobs - #1089

Merged
AchoArnold merged 1 commit into
mainfrom
fix/explicit-web-deployment-jobs
Nov 17, 2026
Merged

AchoArnold merged 1 commit into
mainfrom
fix/explicit-web-deployment-jobs

Conversation

@AchoArnold

Copy link
Copy Markdown
Member

Summary

  • Replace the frontend deployment matrix with two explicit jobs: Deploy Web to Cloudflare and Deploy Web to Firebase.
  • Keep both jobs parallel and dependent on successful API deployment and web build, deploying the same static artifact only on pushes to main.
  • Give each job its own deployment action and provider-specific token permissions, without matrix conditions.

Verification

  • actionlint passed with only its outdated Ubuntu 26.04 runner-label warning filtered (the label was previously verified against official runner documentation).
  • Repository YAML and Prettier checks passed; git diff whitespace check passed.
  • Configuration assertions confirmed distinct jobs without a matrix, identical API/build prerequisites and artifacts, main-only deployment guards, Ubuntu 26.04 runners, and provider-specific permissions.

Husky was skipped with explicit approval because the existing lockfile minimum-release-age violation blocks the hook. Dependency files and policies are unchanged.

Replace the provider matrix with separate Cloudflare and Firebase jobs. Both download the same build and run in parallel after API deployment and web build succeed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a0fd7292-f3aa-4919-929f-d73c2ac0f0c2
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@AchoArnold
AchoArnold merged commit a498919 into main Nov 17, 2026
8 of 10 checks passed
@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; both deployment jobs preserve the existing build and deployment requirements.

Summary

Replaces the frontend deployment matrix with separate Cloudflare and Firebase jobs.

  • Cloudflare and Firebase web deployments run in separate jobs.

No actionable issues were found.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Tests["Integration tests"] --> API["Deploy API"]
  Tests --> Build["Build web and upload artifact"]
  API --> Cloudflare["Deploy web to Cloudflare"]
  API --> Firebase["Deploy web to Firebase"]
  Build --> Cloudflare
  Build --> Firebase
Loading

Reviews (1) · Last reviewed commit: "refactor(ci): split frontend deployments..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant