Skip to content

fix(ci): deploy web after API with run-number versions - #1087

Merged
AchoArnold merged 1 commit into
mainfrom
fix/deploy-web-after-api
Nov 17, 2026
Merged

AchoArnold merged 1 commit into
mainfrom
fix/deploy-web-after-api

Conversation

@AchoArnold

Copy link
Copy Markdown
Member

Summary

  • Enforce the production order: integration tests → successful API deployment → frontend validation and deployment to Cloudflare and Firebase.
  • Reuse the web workflow from the API workflow instead of deploying the frontend independently on pushes. Preserve standalone frontend validation on pull requests.
  • Use the API workflow's github.run_number for API image tags, the API binary version, and the frontend client version. The reusable workflow inherits the caller's run number, keeping both components on the same increasing version; retries retain their original version.

Verification

  • actionlint passed for both workflows.
  • Repository YAML, formatting, end-of-file, and whitespace checks passed.
  • Frontend ESLint and Prettier checks passed using the installed executables.
  • Configuration assertions verified deployment dependencies, main-only deployment guards, caller permissions, and version propagation through Cloud Build and the API Dockerfile.
  • Loaded the Nuxt configuration to verify numeric run versions and the local dev fallback.

Note

The existing lockfile violates pnpm's 24-hour minimum release-age policy, blocking the pnpm wrapper and Husky hook. Targeted checks were run directly with installed tools; Husky was skipped for this commit with explicit approval. Dependency files and supply-chain policy were not changed. Production deployment will occur after merge.

Run the web workflow only after integration tests and a successful API deployment. Use the API workflow run number for API image tags, binary versions, and the frontend client version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a0fd7292-f3aa-4919-929f-d73c2ac0f0c2
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

This PR makes production frontend deployment wait for a successful API deployment.

  • The web app deploys only after the API finishes deploying.
  • The API and web app use the same run number as their version.
  • The web workflow keeps Node version 24.18.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Push[Push to main] --> Tests[Integration tests]
  Tests --> API[Build and deploy API]
  API --> Validate[Validate frontend]
  Validate --> Build[Build frontend]
  Build --> Cloudflare[Deploy to Cloudflare]
  Cloudflare --> Firebase[Deploy to Firebase]
  PR[Pull request] --> PRValidate[Standalone frontend checks]
Loading

Reviews (1) · Last reviewed commit: "fix(ci): deploy web after API with run-n..." · Reviewed by Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the coordinated API and frontend deployment changes.

No open issues 🎉

What changed in this PR

This PR coordinates httpSMS production deployments so frontend validation and deployment follow a successful API deployment, with both components using the API workflow’s run number as their version.

Changes:

  • Call the reusable web workflow after API deployment while preserving standalone frontend validation on pull requests.
  • Pass the run number through Cloud Build for API image tags and the compiled binary version.
  • Use the inherited run number for the frontend client version, retaining the local dev fallback.
File Description
web/​nuxt.config.ts Uses GITHUB_RUN_NUMBER for the client version.
api/​Dockerfile Embeds the VERSION build argument in the API binary.
api/​cloudbuild.yaml Uses _VERSION for image tags, builds, and deployment.
.github/​workflows/​web.yml Enables reusable invocation, retains PR validation, and removes SHA injection.
.github/​workflows/​api.yml Supplies the run-number version and calls the web workflow after API deployment.

Review effort: Balanced

@AchoArnold
AchoArnold merged commit 70836ef into main Nov 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants