fix(runtime): entered context in Runtime entry points#318
Closed
adrian-niculescu wants to merge 1 commit intoNativeScript:mainfrom
Closed
fix(runtime): entered context in Runtime entry points#318adrian-niculescu wants to merge 1 commit intoNativeScript:mainfrom
adrian-niculescu wants to merge 1 commit intoNativeScript:mainfrom
Conversation
Added Context::Scope to Runtime::RunMainScript, Runtime::RunModule, and Runtime::RunScript to ensure the runtime's context is explicitly entered before delegating to ModuleInternal. While the context is already entered once in Runtime::Init and remains current for the runtime's lifetime, this change adds a defensive context scope at each entry point for consistency and future-proofing.
adrian-niculescu
force-pushed
the
fix/runtime-runmain-context-scope
branch
from
71c0601 to
6156b29
Compare
adrian-niculescu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Context::Scope to
Runtime::RunMainScript,Runtime::RunModule, andRuntime::RunScriptto ensure the runtime's context is explicitly entered before delegating to ModuleInternal.Rationale
While the context is already entered once in
Runtime::Init()and remains current for the runtime's lifetime, this change adds a defensive context scope at each entry point for:No functional behavior change is expected for existing apps.