Make nav buttons readable over dark content - #509
Merged
Conversation
Ultra, Masterclass and Build now use the same pill as the Mobile and Desktop dropdowns, so they keep their contrast when the sticky nav floats over dark images. The Bifrost button just says Bifrost instead of cycling through words. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ultra, Masterclass and Build links in the desktop nav were tinted pills with a 10% background and coloured text. When the sticky nav blurs over something dark, like a blog post hero image, they lost almost all their contrast. They now use the same classes as the Mobile and Desktop dropdown buttons. That means they lose their orange, green and violet colours.
The Bifrost button no longer cycles through "Try Bifrost!", "Build", "Distribute" and "Ship". It just says "Bifrost", in the nav and in the mobile menu. I removed the GSAP timeline and hover handlers that ran the rotation, and kept the spinning gradient border. The label now has
relativeso it paints above the button's white inner layer. The GSAP transforms had been doing that by accident.NavigationBarTest checks the button label and that the three links carry the Mobile dropdown's resting background classes. It reads those classes from the dropdown's Alpine
:classbinding, so restyling the dropdown will fail the test until the links are updated to match. Both tests fail against the old markup. I also checked the nav with screenshots in light and dark mode, at desktop width and in the mobile menu.🤖 Generated with Claude Code