Add Jump compatibility indicators for plugins and EDGE docs#445
Draft
simonhamp wants to merge 1 commit into
Draft
Add Jump compatibility indicators for plugins and EDGE docs#445simonhamp wants to merge 1 commit into
simonhamp wants to merge 1 commit into
Conversation
Surfaces Bifrost's Jump preview app in two places: - Plugins: a manual `works_in_jump` flag (admin-controlled via Filament) rendered as a pill on the plugin detail page and marketplace cards. - Docs: a collapsible QR code in the right sidebar of Mobile v4 EDGE component pages, deep-linking into Jump. Visitors who scan without the app installed get an overlay with platform-detected store buttons. Also extracts Jump's public identity into App\Support\JumpApp so the deep-link association files and the docs UI share one source of truth, and fixes a Cache::flush() race in the docs controller that could throw FilesystemIterator errors on concurrent local requests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaces Jump — Bifrost's mobile preview app — in two places it was previously invisible.
Plugins: "Works in Jump" pill
Jump is a pre-built binary containing only NativePHP's core native APIs, so a plugin shipping its own Kotlin/Swift bridge functions can't run in it. That's a judgment call rather than something reliably derivable from a manifest, so this adds a manual
works_in_jumpflag:false;worksInJump()helper mirrors the existingisOfficial()/isActive()conventionsDocs: scannable QR on EDGE component pages
Mobile v4 EDGE component pages now show a collapsible QR card in the right sidebar (between "Copy as Markdown" and the ads), encoding that page's docs URL plus a
?jump=qrmarker:/docs/*deep link straight into the app (already claimed via the existing AASA/assetlinks files)Two deliberate details worth reviewing:
hidden xl:flex, and the overlay is rendered by the phone, so putting it there would hide it exactly where it's needed.nativephp.com. Jump only claims deep links for that domain, and a phone can't resolve a local/preview hostname — a QR built fromurl()would be unscannable outside production.Scoped strictly to Mobile v4: EDGE sections also exist in Mobile v2 and v3, and this must not appear there.
Incidental fixes
App\Support\JumpApp— the deep-link association files and the docs UI now share one source of truth for Jump's bundle IDs and store URLs, instead of duplicating them acrossApplinksControllerand docs markdown.Cache::flush()race inShowDocumentationController. It ran on every local docs request; concurrent requests could delete a hashed cache subdirectory mid-iteration, throwingFilesystemIterator ... Failed to open directory(hit while testing this branch). Local now bypasses the docs cache instead of flushing globally — same always-fresh-in-dev intent, no race, and no longer wipes unrelated cache entries.Testing
25 new tests across 6 files, all passing alongside the existing docs suite (56 total):
ApplinksTestlocks theJumpAppextractionDocsCachingTestlocks the cache-race fixAlso verified end-to-end against a live dev site: the rendered QR SVG is byte-identical to one generated from the canonical URL, confirming the actual scannable payload.
Note for reviewers
The QR points at production
nativephp.com, so scanning it before this merges will exercise the deep-link path but not the overlay — production has no?jump=qrhandler until this ships. To try the overlay now, load an EDGE page locally with?jump=qrunder device emulation.🤖 Generated with Claude Code