Skip to content

Scroll the current feed to the top when Log is tapped again - #142

Draft
Matildevoldsen wants to merge 1 commit into
NativePHP:mainfrom
Matildevoldsen:fix/log-tab-scroll-to-top
Draft

Matildevoldsen wants to merge 1 commit into
NativePHP:mainfrom
Matildevoldsen:fix/log-tab-scroll-to-top

Conversation

@Matildevoldsen

@Matildevoldsen Matildevoldsen commented Oct 31, 2026 •

Copy link
Copy Markdown

Depends on NativePHP/mobile-air#637 being merged and released. Keep this PR as a draft.

Draft for making a repeat tap on the bottom Log button return the current feed to its top. It will reuse the existing feed reset action, preserve Following/Latest/Trending and the loaded commits, and keep normal navigation from other tabs.

The current head adds regression coverage for the existing scroll-to-top action on all three feeds and both platform configurations. The tests verify that the feed, loaded commit order and pagination survive, and no extra refresh or navigation is triggered. The bottom-tab callback and public NativePHP fork pin will be added after baseline captures.

Refs #113. Related work in #79 includes Android reselect with broader refresh/navigation changes; this draft is limited to returning the current feed to the top.

Remaining work:

  • Capture the unchanged signed-in feed on iOS and Android.
  • Wire the bottom Log reselect callback and test that actual callback path.
  • Pin the public NativePHP PR revision for testing; replace it with the released upstream version before merge.
  • Compile and verify the integrated app on both platforms.
  • Publish before/after screenshots and scrolling recordings in light and dark mode.

Validation at d7991a4: php artisan test --compact passes 1,706 tests / 16,257 assertions, with one existing skipped test. Pint passes. The six new cases cover all three feeds on both platform configurations.

Screenshots

Pending account sign-in on the fresh test simulators. The unchanged app compiles and launches on both platforms. No visual verification is claimed, and the screenshot/recording requirements are not waived.

  • No visible change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant