Repository navigation
Scroll the current feed to the top when Log is tapped again - #142
Draft
Matildevoldsen wants to merge 1 commit into
Draft
Matildevoldsen wants to merge 1 commit into
Matildevoldsen wants to merge 1 commit into
Conversation
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on NativePHP/mobile-air#637 being merged and released. Keep this PR as a draft.
Draft for making a repeat tap on the bottom Log button return the current feed to its top. It will reuse the existing feed reset action, preserve Following/Latest/Trending and the loaded commits, and keep normal navigation from other tabs.
The current head adds regression coverage for the existing scroll-to-top action on all three feeds and both platform configurations. The tests verify that the feed, loaded commit order and pagination survive, and no extra refresh or navigation is triggered. The bottom-tab callback and public NativePHP fork pin will be added after baseline captures.
Refs #113. Related work in #79 includes Android reselect with broader refresh/navigation changes; this draft is limited to returning the current feed to the top.
Remaining work:
Validation at
d7991a4:php artisan test --compactpasses 1,706 tests / 16,257 assertions, with one existing skipped test. Pint passes. The six new cases cover all three feeds on both platform configurations.Screenshots
Pending account sign-in on the fresh test simulators. The unchanged app compiles and launches on both platforms. No visual verification is claimed, and the screenshot/recording requirements are not waived.