Repository navigation
Conversation
mnapoli
marked this pull request as ready for review
October 31, 2026 16:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings → Devices on dev-null.sh only shows the device's name, so apps can't be told apart there. The app now sends its own name when it opens
/mobile/authorize:app_nameis "/dev/null for iOS" or "/dev/null for Android", usingSystem::isIos(). The web then shows "/dev/null for iOS on iPhone" (dev-null-sh/dev-null.sh#1339).It also sends a stable
app_id, which stays when the name changes:ios:orandroid:followed by the bundle id fromconfig('nativephp.app_id'). The two platforms get different ids because they are different apps, even with the same bundle id. If a build's.envdoesn't carry the bundle id, it sends the release one,com.nativephp.devnull.device_namebecomes just the model ("iPhone", "Pixel 9"), because the web now adds the app's name in front of it. Otherwise it would read "/dev/null for iOS on devnull on iPhone".Depends on dev-null-sh/dev-null.sh#1339. Please release this only after #1339 is deployed. Before that, the server ignores
app_name, so phones approved in between would show as just "iPhone" until they are approved again.Sign in with Apple uses the same device name and doesn't send
app_nameyet: its server endpoint isn't live. It can send it once that endpoint exists.Tests:
composer setup:free, thenphp artisan test: 1700 passed, 1 skipped. Pint passes on the changed files.Screenshots
Nothing changes in the app itself, only the URL it opens to sign in.