Match Linux development window icons#130
Draft
SRWieZ wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Give Linux apps launched by
native:runa stable development desktop identity and a matching hidden XDG desktop entry.desktopNamebefore launch$XDG_DATA_HOME/applications(falling back to~/.local/share/applications)StartupWMClassWhy
Linux shells resolve a running window's taskbar or dock icon through its desktop identity. Electron otherwise uses the development package name, which has no application-specific desktop entry, so the window may show a generic icon while the tray uses the application's icon.
Electron reads
desktopNamebefore creating the app and exposes it as the Wayland app ID and X11 WM class. The matching desktop entry follows the freedesktop convention used by KDE, GNOME, and other compliant desktops.Coexistence and DX
Development never reuses the production desktop ID. Its identity includes a
nativephp-devmarker and a checkout-path hash, so production builds and parallel checkouts remain separate. The entry is hidden from launchers, refreshed atomically on later runs, and failure to write it only emits a warning. macOS, Windows, and production builds are unchanged.Validation
resourceClassanddesktopFileName