Await PHP binary extraction before starting Electron#129
Open
SRWieZ wants to merge 1 commit into
Open
Conversation
SRWieZ
marked this pull request as ready for review
July 18, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
php.jspreviously started the callback-basedyauzlextraction and returned immediately. Because the package script chains it withelectron-vite dev, Electron could start while the PHP binary was still being written or beforechmodcompleted. On Linux this produced partial binaries, permission errors, and intermittent startup failures.Developer impact
NativePHP development startup now continues only after the bundled PHP executable is complete and runnable. Missing or unreadable archives also stop the package script instead of allowing startup to proceed with an invalid runtime.
Validation
npx prettier --check php.jsnpx eslint php.jsnode --check php.jsphp --versionimmediately after the script exited