Fix custom PHP binary deleted when binary path is the app root

[simonhamp]

Summary

Fixes #115.

When NATIVEPHP_PHP_BINARY_PATH is set to a value that points at the project root (e.g. ./), native:build deletes the entire built app right before electron-builder packages it.

Root cause

In PrunesVendorDirectory::pruneVendorDirectory(), the configured binary package directory was interpolated naively into "app/{$binaryPackageDirectory}". When the value normalizes to a no-op (./, ., /, or a trailing /.), Path::join('/build', 'app/./') collapses to /build/app, so the prune step removes the whole app directory. The previous ! empty() guard did not catch this because strings like ./ are non-empty.

native:run was unaffected because it does not run the prune step.

Fix

Trim the configured path of surrounding dots, slashes, and whitespace, then skip removal entirely when nothing meaningful remains:

$binaryPackageDirectory = trim($this->binaryPackageDirectory(), "./\\ \t\n\r\0\x0B");
if ($binaryPackageDirectory !== '' && $filesystem->exists($this->buildPath("app/{$binaryPackageDirectory}"))) {
    $filesystem->remove($this->buildPath("app/{$binaryPackageDirectory}"));
}

Tests

Added tests/Build/PruneVendorDirectoryTest.php:

• A normal custom binary directory (php-bin/) is still pruned.
• A path that normalizes to the app root (./) no longer wipes the built app (regression test for Custom PHP binary gets deleted if in root of project #115).

Verified the regression test fails against the old code and passes with the fix. Full suite (114 tests) passes and Pint is clean.

🤖 Generated with Claude Code

[simonhamp]

@bmckay959 would you mind trying this fix out when you get a chance?

[bmckay959]

I'm a bit confused by this test....why do we want the custom binary removed? Feels like this test is introducing the bug the opposite direction? Basically, we don't want to delete the directory where the NATIVEPHP_PHP_BINARY points....or am I missing something?

[gwleuverink]

Understandable confusion. The binary is moved to a location in the app bundle itself during build. So leaving it in the source directory would include it twice 👍🏻