[FINNA-3708] Refactor LIDO record handling to use VuFindXml.#199
Open
EreMaijala wants to merge 1 commit into
Open
[FINNA-3708] Refactor LIDO record handling to use VuFindXml.#199EreMaijala wants to merge 1 commit into
EreMaijala wants to merge 1 commit into
Conversation
This improves namespace support for LIDO records.
mshroom
requested changes
Jun 17, 2026
mshroom
left a comment
mshroom
left a comment
Contributor
There was a problem hiding this comment.
Muutama kohta tässä, mutta en ehtinyt katsoa vielä kokonaan
| if (!empty($result)) { | ||
| return $result; | ||
| } | ||
| if ('' !== ($result = $this->xmlDoc->firstValue($place, 'partOfPlace') ?? '')) { |
Contributor
There was a problem hiding this comment.
partOfPlace ei sisällä tekstiä vaan pitää kutsua tätä getSubLocationia uudestaan niinkuin aiemmin. Tyyliin:
if ($partOfNode = $this->xmlDoc->first($place, 'partOfPlace') {
$result = $this->getSubLocation($partOfNode, true);
if ('' !== $result) {
return $result;
}
}
| = $this->xmlDoc->firstValue($placeNode, 'place/namePlaceSet/appellationValue') ?? ''; | ||
| if ('' !== $appellationValue) { | ||
| $mainPlace = $appellationValue; | ||
| $placeNode = $this->xmlDoc->first($placeNode, 'place'); |
Contributor
There was a problem hiding this comment.
voisiko tässä $placeNode olla vaikka $subPlaceNode, ei toi nyt taida sotkea mitään mutta vaikeuttaa ymmärtämistä kun $placeNode on jo tuossa käytössä eri elementillä
Comment on lines
+616
to
+619
| if (!($descriptiveNoteValue = $this->xmlDoc->first($set, 'descriptiveNoteValue'))) { | ||
| continue; | ||
| } | ||
| if ('' === ($value = $this->xmlDoc->value($descriptiveNoteValue))) { |
Contributor
There was a problem hiding this comment.
Eikö tässä olis kätevämpää vain tarkistaa firstValue($set, 'descriptiveNoteValue')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves namespace support for LIDO records.