Open
Conversation
jason-lachance
requested changes
Oct 17, 2018
Collaborator
jason-lachance
left a comment
jason-lachance
left a comment
There was a problem hiding this comment.
Basics look good, but I suspect you mean to append to, not overwrite, the log file.
| mkdir -p logs/ | ||
| destdir=logs/promotion-list | ||
| echo "Saving list of updated resource groups to logs/promotion-list" | ||
| echo "$groups" > "$destdir" No newline at end of file |
Collaborator
There was a problem hiding this comment.
Are you wanting to keep appending to logs/promotion-list or to overwrite it? You probably want >> here.
| ./update-group-tag-by-name.sh $name Environment=production | ||
| done | ||
| # Output production group list to file. | ||
| mkdir -p logs/ |
Collaborator
There was a problem hiding this comment.
Might also be helpful to write out a timestamp here so we know when this was last run. I'm thinking about the case where you run it multiple times in the same directory -- and you want the output to be appended so you don't lose the last output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.