Skip to content

fix(ecs): type error in editor manifest #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinFillon merged 1 commit into from
Dec 7, 2025
Merged

fix(ecs): type error in editor manifest #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions packages/ecs-lib/src/editor-manifest.type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* @param Type - Type of the element
* @param Default - Type of the element's default value
*/
type ECElementDefaults<Type, Default> = {
type ECSElementDefaults<Type, Default> = {
/**
* Type of the element
*/
Expand Down Expand Up @@ -42,57 +42,57 @@ type ECElementDefaults<Type, Default> = {
* * Editor Component String Element
* Type for string element
*/
type ECStringElement = {
type ECSStringElement = {
/**
* Values allowed for the element
*/
enum?: string[];
} & ECElementDefaults<"string", string>;
} & ECSElementDefaults<"string", string>;

/**
* * Editor Component Number Element
* Type for number element
*/
type ECNumberElement = ECElementDefaults<"number", number>;
type ECSNumberElement = ECSElementDefaults<"number", number>;

/**
* * Editor Component Boolean Element
* Type for boolean element
*/
type ECBooleanElement = ECElementDefaults<"boolean", boolean>;
type ECSBooleanElement = ECSElementDefaults<"boolean", boolean>;

/**
* * Editor Component Array Element
* Type for array element
*/
type ECArrayElement = {
type ECSArrayElement = {
/**
* Items of the array
*/
items: ECElement;
} & ECElementDefaults<"array", any[]>;
items: ECSElement;
} & ECSElementDefaults<"array", any[]>;

/**
* * Editor Component Object Element
* Type for object element
*/
type ECObjectElement = {
type ECSObjectElement = {
/**
* Properties of the object
*/
properties: Record<string, ECElement>;
} & ECElementDefaults<"object", object>;
properties: Record<string, ECSElement>;
} & ECSElementDefaults<"object", object>;

/**
* * Editor Component Element
* Type for component element
*/
type ECElement =
| ECStringElement
| ECNumberElement
| ECBooleanElement
| ECArrayElement
| ECObjectElement;
type ECSElement =
| ECSStringElement
| ECSNumberElement
| ECSBooleanElement
| ECSArrayElement
| ECSObjectElement;

/**
* Manifest for a component to be used in the NanoForge Editor
Expand All @@ -111,7 +111,7 @@ export type EditorComponentManifest = {
/**
* Parameters of the component
*/
params: Record<string, ECElement>;
params: Record<string, ECSElement>;
};

/**
Expand Down
Loading