Include eps_parameters for plot3D#3205
Open
drinwater wants to merge 8 commits intoNanoComp:masterfrom
Open
Conversation
stevengj
reviewed
Apr 24, 2026
stevengj
previously approved these changes
Apr 24, 2026
stevengj
reviewed
Apr 24, 2026
stevengj
reviewed
Apr 24, 2026
stevengj
reviewed
Apr 24, 2026
| eps_data = np.round(np.real(sim.get_epsilon_grid(xtics, ytics, ztics)), 2) | ||
|
|
||
| unique = np.unique(np.abs(eps_data)).tolist() | ||
| eps_data = np.round(np.real(sim.get_epsilon_grid(xtics, ytics, ztics, eps_frequency)), 2) |
Collaborator
There was a problem hiding this comment.
Not sure why we are rounding here?
Author
There was a problem hiding this comment.
Previous versions of vispy used to throw an error when not rounded for some reason back when plot3D was first added. I will remove this now since that issue seems to be fixed.
stevengj
reviewed
Apr 24, 2026
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
stevengj
reviewed
Apr 24, 2026
| unique = np.unique(eps_data).tolist() | ||
|
|
||
| # Remove background material | ||
| unique.remove(np.round(np.abs(np.asarray(sim.default_material.epsilon_diag)), 2)[0]) |
Collaborator
There was a problem hiding this comment.
@smartalecH, do you remember why round was being used here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently plot3D cannot plot materials with frequency-dependent epsilon. This PR fixes that by including eps_parameters kwarg in plot3D