Repository navigation
Release 1.0.2: a notification no longer loops between delegates - #21
Merged
Merged
Conversation
The four packages go to 1.0.2 together, and the three adapters now ask for flutwire ^1.0.2. flutwireVersion and the podspec follow, which version_test checks. The entries that were waiting under Unreleased are now under [1.0.2], each package has its own changelog entry, and the README says what shipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four packages go to 1.0.2: one fix that is already on main, and a check in CI. On iOS and macOS, a notification that was not Flutwire's closed an app that also has Firebase Messaging when it was tapped, or when it arrived with the app open. The plugin remembered one delegate each time it took the notification center, and Firebase Messaging, which keeps the delegate it replaces to pass every call on to, could sit between the plugin's two takes, so the two handed a call back and forth until the stack ran out. The plugin now keeps every delegate it replaces and hands a call to each of them once, and the Apple job of CI runs a model of the delegates that loops in the old order and passes in the new one.
This is a patch: it fixes one fault and adds nothing to the API, which the api job of CI checks against 1.0.1 on pub.dev. The release commit moves the four pubspecs, the three adapter constraints, flutwireVersion and the podspec, which version_test checks, and the entries that were under Unreleased now sit under [1.0.2]. The README gains one line in its roadmap.
The format check, the analyzer, the four test suites and the publish dry run of each package pass locally, and the audit script reports the repository at standard. The fix has not been seen on a device yet; that happens in the app once 1.0.2 is on pub.dev. The tag comes after the merge.