Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ endfunction()
function(def_example example)
split(${example} target source)
add_executable(${target} ${source})
target_compile_options(${target} PUBLIC
$<$<CXX_COMPILER_ID:GNU>:-Wno-maybe-uninitialized>) # warnings being emitted from stdlib headers, why?
target_link_libraries(${target}
PRIVATE STDEXEC::stdexec
stdexec_executable_flags
$<TARGET_NAME_IF_EXISTS:TBB::tbb>)
target_compile_options(${target} INTERFACE
$<$<CXX_COMPILER_ID:GNU>:-Wno-maybe-uninitialized>) # warnings being emitted from stdlib headers, why?
endfunction()

set(stdexec_examples
Expand Down
1 change: 0 additions & 1 deletion include/exec/detail/system_context_replaceability_api.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "../../stdexec/__detail/__execution_fwd.hpp"
#include "../../stdexec/__detail/__system_context_replaceability_api.hpp"

#include <cstddef>
#include <memory>

namespace experimental::execution::system_context_replaceability
Expand Down
1 change: 0 additions & 1 deletion include/exec/execute.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "../stdexec/__detail/__execution_fwd.hpp"

#include "../stdexec/__detail/__concepts.hpp"
#include "../stdexec/__detail/__receivers.hpp"
#include "../stdexec/__detail/__schedulers.hpp"
#include "../stdexec/__detail/__senders.hpp"
#include "../stdexec/__detail/__then.hpp"
Expand Down
3 changes: 1 addition & 2 deletions include/exec/sequence_senders.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -849,10 +849,9 @@ namespace experimental::execution
return STDEXEC::connect(static_cast<next_sender_of_t<_Receiver, __tfx_seq_t>&&>(__next),
__stopped_means_break<_Receiver>{
static_cast<_Receiver&&>(__rcvr)});
// NOLINTNEXTLINE(bugprone-branch-clone)
}
else if constexpr (__subscribable_with_static_member<__tfx_seq_t, _Receiver>)
{
{ // NOLINT(bugprone-branch-clone)
return __tfx_seq.subscribe(static_cast<__tfx_seq_t&&>(__tfx_seq),
static_cast<_Receiver&&>(__rcvr));
}
Expand Down
3 changes: 2 additions & 1 deletion include/stdexec/__detail/__any.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1198,7 +1198,8 @@ namespace STDEXEC::__any
[[nodiscard]]
static constexpr auto __value_(_Self &&__self) noexcept -> auto &&
{
using __from_ref_t = __if_c<std::is_lvalue_reference_v<_Self>, _Value &, _Value &&>;
using __from_ref_t
[[maybe_unused]] = __if_c<std::is_lvalue_reference_v<_Self>, _Value &, _Value &&>;
using __to_ref_t = __copy_cvref_t<_Self &&, __value_type>;

STDEXEC_IF_NOT_CONSTEVAL
Expand Down
1 change: 0 additions & 1 deletion include/stdexec/__detail/__atomic_intrusive_queue.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "__intrusive_queue.hpp"

#include <cassert>
#include <cstddef>

namespace STDEXEC
{
Expand Down
4 changes: 2 additions & 2 deletions include/stdexec/__detail/__bulk.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ namespace STDEXEC
__with_error_invoke_t<_AlgoTag, _Fun, _Shape, _CvSender, _Env...>>;

template <class _AlgoTag>
struct __generic_bulk_t
{ // NOLINT(bugprone-crtp-constructor-accessibility)
struct __generic_bulk_t // NOLINT(bugprone-crtp-constructor-accessibility)
{
template <sender _Sender,
typename _Policy,
__std::integral _Shape,
Expand Down
28 changes: 13 additions & 15 deletions include/stdexec/__detail/__connect_awaitable.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@
#include "__concepts.hpp"
#include "__config.hpp"
#include "__env.hpp"
#include "__optional.hpp"
#include "__receivers.hpp"

#include <exception>
#include <utility>

STDEXEC_PRAGMA_PUSH()
STDEXEC_PRAGMA_IGNORE_GNU("-Wsubobject-linkage")
Expand Down Expand Up @@ -199,22 +197,22 @@ namespace STDEXEC

union
{
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
__awaitable_t __awaitable_;
};

union
{
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
__awaiter_t __awaiter_;
};
};

[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
_Awaitable __source_awaitable_;
union
{
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
__state __awaiter_;
};

Expand Down Expand Up @@ -277,16 +275,16 @@ namespace STDEXEC

union
{
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
__awaiter_t __awaiter_;
};
};

[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
_Awaitable __source_awaitable_;
union
{
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
__state __awaiter_;
};

Expand Down Expand Up @@ -348,16 +346,16 @@ namespace STDEXEC

union
{
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
__awaiter_t __awaiter_;
};
};

[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
_Awaitable __source_awaitable_;
union
{
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
__state __awaiter_;
};

Expand Down Expand Up @@ -389,7 +387,7 @@ namespace STDEXEC
{
// _Awaitable has neither a distinct awaiter, nor a distinct awaitable
// so we don't need separate storage for either
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
_Awaitable __awaiter_;

template <__not_decays_to<__awaitable_state> _Awaitable2>
Expand Down Expand Up @@ -534,11 +532,11 @@ namespace STDEXEC
}

__synthetic_coro_frame __synthetic_frame_{&__promise_t::__resume};
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
_Receiver __rcvr_;
[[neo_unique_addres]]
__awaitable_state<_Awaitable, __promise_t> __awaiter_;
[[no_unique_address]]
STDEXEC_ATTRIBUTE(no_unique_address)
bool __started_{false};
};
} // namespace __connect_await
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__execution_legacy.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "__config.hpp"

#if !STDEXEC_NO_STDCPP_EXECUTION_POLICY()
# include <execution>
# include <execution> // IWYU pragma: keep
#endif

namespace STDEXEC
Expand Down
1 change: 0 additions & 1 deletion include/stdexec/__detail/__inline_scheduler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "__execution_fwd.hpp"

#include "__completion_behavior.hpp"
#include "__queries.hpp"
#include "__receivers.hpp"
#include "__schedulers.hpp"

Expand Down
3 changes: 1 addition & 2 deletions include/stdexec/__detail/__manual_lifetime.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#pragma once

#include "__concepts.hpp"
#include "__utility.hpp"

#include <memory>
#include <new>
Expand All @@ -36,7 +35,7 @@ namespace STDEXEC
constexpr __manual_lifetime() noexcept = default;

//! Destructor does nothing: It's on you to call `__destroy()` if you mean to.
constexpr ~__manual_lifetime() = default;
constexpr ~__manual_lifetime() {}

STDEXEC_IMMOVABLE(__manual_lifetime);

Expand Down
1 change: 0 additions & 1 deletion include/stdexec/__detail/__ranges.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#pragma once

#include "__config.hpp"
#include "__type_traits.hpp"

#if !STDEXEC_NO_STDCPP_RANGES()

Expand Down
1 change: 0 additions & 1 deletion include/stdexec/__detail/__receiver_ref.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "__concepts.hpp"
#include "__config.hpp"
#include "__execution_fwd.hpp"
#include "__operation_states.hpp"
#include "__receivers.hpp"
#include "__sender_concepts.hpp"

Expand Down
3 changes: 1 addition & 2 deletions include/stdexec/__detail/__spawn_common.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

#include "__concepts.hpp"
#include "__env.hpp"
#include "__queries.hpp"

#include <memory>

Expand Down Expand Up @@ -69,7 +68,7 @@ namespace STDEXEC::__spawn_common
// [exec.spawn] paragraph 9
// [exec.spawn.future] paragraph 15
if constexpr (__callable<get_allocator_t, _Env&>)
{
{ // NOLINT(bugprone-branch-clone)
// (9/15.1) -- if the expression get_allocator(env) is well-formed, then ...
// senv is the expression env;
return static_cast<_Env&&>(__env);
Expand Down
1 change: 0 additions & 1 deletion include/stdexec/__detail/__starts_on.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include "__senders.hpp"
#include "__sequence.hpp"
#include "__utility.hpp"
#include "__write_env.hpp"

namespace STDEXEC
{
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__task.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ namespace STDEXEC
using __callback_fn_t = __forward_stop_request<_StopSource>;
using __stop_callback_t = stop_callback_for_t<_StopToken, __callback_fn_t>;

constexpr __stop_callback_box() {}
constexpr __stop_callback_box() noexcept {}

constexpr ~__stop_callback_box() {}

Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__tuple.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ namespace STDEXEC
noexcept(__nothrow_callable<__impl_t<_Tuple>, _Fn, _Tuple, _Us...>)
-> __call_result_t<__impl_t<_Tuple>, _Fn, _Tuple, _Us...>
{
constexpr size_t __size = STDEXEC_REMOVE_REFERENCE(_Tuple)::__size;
STDEXEC_CONSTEXPR_LOCAL size_t __size = STDEXEC_REMOVE_REFERENCE(_Tuple)::__size;

if constexpr (__size == 0)
{
Expand Down
1 change: 0 additions & 1 deletion include/stdexec/functional.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

#include "concepts.hpp" // IWYU pragma: keep

#include <cstddef>
#include <functional>

namespace STDEXEC
Expand Down
1 change: 1 addition & 0 deletions test/exec/test_any_sender.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ STDEXEC_PRAGMA_IGNORE_MSVC(4702) // unreachable code
STDEXEC_PRAGMA_IGNORE_MSVC(4996) // 'function' was declared deprecated
STDEXEC_PRAGMA_IGNORE_GNU("-Wdeprecated-declarations")
STDEXEC_PRAGMA_IGNORE_EDG(deprecated_entity)
STDEXEC_PRAGMA_IGNORE_EDG(deprecated_entity_with_custom_message)

namespace
{
Expand Down
1 change: 0 additions & 1 deletion test/exec/test_bwos_lifo_queue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#include <algorithm>
#include <atomic>
#include <numeric>
#include <ranges>
#include <thread>
#include <vector>
Expand Down
Loading