fix: sync chart CRD deploymentPolicy type and add smoke test #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0mmylam
requested review from
ayuskauskas,
lockwobr,
mskalka and
riceriley59
as code owners
lockwobr
approved these changes
Dec 19, 2025
riceriley59
approved these changes
Dec 19, 2025
lockwobr
pushed a commit
that referenced
this pull request
Dec 22, 2025
lockwobr
pushed a commit
that referenced
this pull request
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes chart CRD where spec.deploymentPolicy was incorrectly typed as
object instead of string, causing validation errors. Adds a
DeploymentPolicy smoke test to helm-chart-test to catch similar
issues during CI.