Skip to content

feat: add FLARE++ attention and GeoTransolver backend - #1940

Open
mnabian wants to merge 1 commit into
NVIDIA:mainfrom
mnabian:flarepp
Open

feat: add FLARE++ attention and GeoTransolver backend#1940
mnabian wants to merge 1 commit into
NVIDIA:mainfrom
mnabian:flarepp

Conversation

@mnabian

@mnabian mnabian commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@mnabian
mnabian requested a review from coreyjadams as a code owner August 19, 2026 23:52
@copy-pr-bot

copy-pr-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS review map

Current for commit b42e3ca1684c. An approval covers every file listed for that owner; one owner is sufficient for shared files.

@coreyjadams — 2 file(s)
  • examples/cfd/external_aerodynamics/transformer_models/README.md
  • examples/cfd/external_aerodynamics/transformer_models/src/conf/model/geotransolver.yaml

No CODEOWNER

  • physicsnemo/experimental/models/flare/init.py
  • physicsnemo/experimental/models/flare/flare.py
  • physicsnemo/experimental/models/geotransolver/init.py
  • physicsnemo/experimental/models/geotransolver/gale.py
  • physicsnemo/experimental/models/geotransolver/geotransolver.py
  • physicsnemo/experimental/nn/init.py
  • physicsnemo/experimental/nn/flare_attention.py
  • test/experimental/models/flare/test_flare.py
  • test/experimental/nn/test_flare_attention.py
  • test/models/geotransolver/test_gale.py
  • test/models/geotransolver/test_geotransolver.py

Comment /codeowners-info to refresh.

@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds input-conditioned FLARE++ attention and exposes it as a standalone Transolver model and a GeoTransolver attention backend.

  • Implements the three-pass dynamic-routing attention kernel and configurable logit scaling.
  • Integrates GALE_FPP with GeoTransolver context mixing, configuration, exports, and validation.
  • Adds forward, gradient, checkpoint, backend, structured-input, and deployment coverage.

Important Files Changed

Filename Overview
physicsnemo/experimental/nn/flare_attention.py Adds the reusable FLARE++ attention layer with dynamic query synthesis, scale validation, and explicit unsupported-backend handling.
physicsnemo/experimental/models/flare/flare.py Adds the standalone FLAREPlusPlus model and refactors FLARE-family block construction while preserving fixed-query FLARE defaults.
physicsnemo/experimental/models/geotransolver/gale.py Adds GALE_FPP and consolidates FLARE-family geometry/global context mixing without changing default GALE_FA semantics.
physicsnemo/experimental/models/geotransolver/geotransolver.py Exposes backend and attention-scale selection with eager validation and propagation through GeoTransolver blocks.
test/experimental/nn/test_flare_attention.py Verifies FLARE++ formulation, scaling, input-conditioned routing, gradients, and parameter layout.
test/models/geotransolver/test_geotransolver.py Covers end-to-end GALE_FPP construction, context combinations, checkpoints, validation, and structured inputs.

Reviews (1): Last reviewed commit: "feat: add FLARE++ attention and GeoTrans..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant