Add support for building ubuntu22.04 on amd64 #302
Conversation
1. In ubuntu22.04 header file "rpc.h" is no longer stored in "/rpc"
directory. So we use flag WITH_TIRPC to succesfully build.
2. In ubuntu22.04 docker image we install "libeld-dev" package so we
don`t need to build the library. That is why we use WITH_LIBELF
flag.
Signed-off-by: Dmitrii Chervov <dschervov1@yandex.ru>
|
@elezar can you please check my PR? |
|
|
||
| # Supported OSs by architecture | ||
| AMD64_TARGETS := ubuntu20.04 ubuntu18.04 ubuntu16.04 debian10 debian9 | ||
| AMD64_TARGETS := ubuntu22.04 ubuntu20.04 ubuntu18.04 ubuntu16.04 debian10 debian9 |
There was a problem hiding this comment.
Same comment as on NVIDIA/nvidia-container-toolkit#1004
Do we want to add arm64 builds here too?
There was a problem hiding this comment.
I am apologize @elezar for long wait... All this time i try to find the ARM machine but without a success((( It will be an honor to me if you merge my request as it is, because i cant for 100% (like in this PR NVIDIA/nvidia-container-toolkit#1004 where i test on actuall ARM machine corretness) say that it will work on arm...
Yes, it will almost work good! What can stop the build it from correct execution? Its just a change of architecture... But i respect you, so i cant spoil my PR with lies...
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
bot
added
the
lifecycle/stale
|
Dear gitlab, please remove the |
|
@elezar jentle ping... My PR is fully correct, why does the bot is wanted to close it? Please dont do it mister bot.... |
2 participants
Manual build for libnvidia-container is necessary! It can help open source community with debug and adding new features to this magnificent library!
Manual build correct working was tested by me on ubuntu22.04 (run docker with gpus all on different models).