Skip to content

docs: Update nico-core architecture diagram#3876

Open
Matthias247 wants to merge 1 commit into
NVIDIA:mainfrom
Matthias247:fiximg
Open

docs: Update nico-core architecture diagram#3876
Matthias247 wants to merge 1 commit into
NVIDIA:mainfrom
Matthias247:fiximg

Conversation

@Matthias247

Copy link
Copy Markdown
Contributor

Related issues

Update the diagram to reflect the latest state of the codebase

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@Matthias247
Matthias247 requested a review from polarweasel as a code owner July 22, 2026 23:29
@copy-pr-bot

copy-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 321b5058-07d1-437d-a9ff-ac59c76d420e

📥 Commits

Reviewing files that changed from the base of the PR and between 4470228 and a897449.

⛔ Files ignored due to path filters (1)
  • docs/static/nico-core.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • docs/static/nico-core.drawio

Summary by CodeRabbit

  • Documentation
    • Updated the architecture diagram layout framing and visual spacing.
    • Refreshed styling for the “NVLink Logical Partitions” and “NVLink Monitor” nodes with a new green theme.
    • Removed outdated status indicators and added a new “VPC Prefixes” node with updated geometry for clearer presentation.

Walkthrough

The Draw.io architecture diagram was updated with new layout offsets, green styling for NVLink nodes, and a VPC Prefixes node replacing the previous status nodes.

Changes

Architecture diagram updates

Layer / File(s) Summary
Diagram layout and node updates
docs/static/nico-core.drawio
The diagram offsets were adjusted, NVLink nodes were restyled from orange to green, and the previous status nodes were replaced with VPC Prefixes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating the nico-core architecture diagram.
Description check ✅ Passed The description is clearly related to the diagram update and matches the stated PR objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Matthias247
Matthias247 enabled auto-merge (squash) July 22, 2026 23:31
Update the diagram to reflect the latest state of the codebase

Signed-off-by: Matthias Einwag <meinwag@nvidia.com>
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants