feat: Log every gRPC call on server and client paths in Flow#2276
Open
kunzhao-nv wants to merge 3 commits into
Open
feat: Log every gRPC call on server and client paths in Flow#2276kunzhao-nv wants to merge 3 commits into
kunzhao-nv wants to merge 3 commits into
Conversation
Adds a shared grpclog package and wires unary interceptors into both the Flow gRPC server and the Core (NICo) gRPC client. Each RPC now emits one structured log line with method, duration_ms, status code, and peer or target. Payloads are intentionally not logged: AddExpectedMachine / AddExpectedSwitch carry BMC credentials. Log level is derived from the status code: OK and expected business outcomes (NotFound, AlreadyExists, ...) at Info; transient outcomes (DeadlineExceeded, Aborted) at Warn; infrastructure failures (Unavailable, Internal) at Error. Same classifier on both sides so a given code reads identically wherever it surfaces. Closes the observability gap in step 4 of the documented debug flow (REST -> workflow -> activity -> Flow -> Core), which previously had zero per-RPC logs in either direction. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
Bump the per-component verification stage from 4m / 3m (stage / action) to 20m / 5m. The previous values left the inner verify-power-status action with only 3m to converge, which is tight for PowerShelves and NVSwitches after a forced power transition. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kunzhao-nv
changed the title
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-06-05 23:01:20 UTC | Commit: 4c30d23 |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
… Core Each inventory sync iteration now logs one summary line with compute / nvswitches / powershelves counts received from Core's GetMachines / GetAllExpectedSwitchesLinked / GetAllExpectedPowerShelvesLinked calls. Lets operators sanity-check "did Core return anything for this type?" without grepping per-component logs. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
aswaroop-nv
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
flow/internal/common/grpclog/with unary interceptors and wire them into the Flow gRPC server and the NICo (Core) gRPC client. One structured log line per RPC:grpc.service/grpc.method/grpc.code/grpc.duration_ms/grpc.peerorgrpc.target. Level by status code. No payloads (BMC creds).Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes