Don't run both check-format-flow and check-format-nightly in pre-comm…#2271
Open
kensimon wants to merge 2 commits into
Open
Don't run both check-format-flow and check-format-nightly in pre-comm…#2271kensimon wants to merge 2 commits into
kensimon wants to merge 2 commits into
Conversation
…it-verify-workspace check-format-nightly subsumes check-format-flow, and the latter was causing spurious warnings about unsupported nightly-only options (becauase we use options only available in nightly rustfmt, hence the custom make task.) Also fix hallucinated "nico-lints" that doesn't exist (they're still called carbide-lints)
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…it-verify-workspace
Description
check-format-nightly subsumes check-format-flow, and the latter was causing spurious warnings about unsupported nightly-only options (becauase we use options only available in nightly rustfmt, hence the custom make task.)
Also fix hallucinated "nico-lints" that doesn't exist (they're still called carbide-lints)
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes