Allow enabling/disabling tracing in nico-api config TOML#2263
Open
kensimon wants to merge 2 commits into
Open
Conversation
This permits site operators to enable OTLP tracing by default, and even prevent it from being toggled at runtime. It also lets the OTLP endpoint be configured via the config.toml, with the env var still working as an override.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
@nvaprado FYI |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-2263.docs.buildwithfern.com/infra-controller |
wminckler
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This permits site operators to enable OTLP tracing by default, and even prevent it from being toggled at runtime. It also lets the OTLP endpoint be configured via the config.toml, with the env var still working as an override.
Type of Change
Related Issues (Optional)
#2262
Breaking Changes
Testing
Additional Notes