fix(preingestion): make BMC time-sync failures recoverable#2260
Open
wminckler wants to merge 1 commit into
Open
fix(preingestion): make BMC time-sync failures recoverable#2260wminckler wants to merge 1 commit into
wminckler wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Two Supermicro machines got stuck in a terminal pre-ingestion Failed state with "BMC time synchronization failed after reset attempt". The BMC clocks were actually fine; the failure was a transient out-of-sync condition at probe time that became permanent, and the only recovery was force-deleting and rediscovering the endpoint. Fix #1: retry instead of failing terminally. TimeSyncReset now carries an attempt counter; when the post-reset recheck is still out of sync it re-enters the reset cycle (each with its 20-minute boot wait) up to MAX_TIME_SYNC_RESET_ATTEMPTS before going Failed, giving a slow-to-NTP-sync BMC time to converge. Fix #2: make "clear error" actually retry. The terminal failure lives in preingestion_state, not the exploration report that clear_last_known_error touched, so clearing the error left the host stuck. clear_site_exploration_error now also resets a Failed preingestion back to Initial (non-failed states untouched), so operators can retry without force-deleting the endpoint. Adds a configurable BMC clock offset to the Redfish sim so the previously untested out-of-sync path can be exercised, plus tests for the retry-then-fail behavior and the clear-error reset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> see bug 6126941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Supermicro machines got stuck in a terminal pre-ingestion Failed state with "BMC time synchronization failed after reset attempt". The BMC clocks were actually fine; the failure was a transient out-of-sync condition at probe time that became permanent, and the only recovery was force-deleting and rediscovering the endpoint.
Fix 1: retry instead of failing terminally. TimeSyncReset now carries an attempt counter; when the post-reset recheck is still out of sync it re-enters the reset cycle (each with its 20-minute boot wait) up to MAX_TIME_SYNC_RESET_ATTEMPTS before going Failed, giving a slow-to-NTP-sync BMC time to converge.
Fix 2: make "clear error" actually retry. The terminal failure lives in preingestion_state, not the exploration report that clear_last_known_error touched, so clearing the error left the host stuck. clear_site_exploration_error now also resets a Failed preingestion back to Initial (non-failed states untouched), so operators can retry without force-deleting the endpoint.
Adds a configurable BMC clock offset to the Redfish sim so the previously untested out-of-sync path can be exercised, plus tests for the retry-then-fail behavior and the clear-error reset.
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes