nvue-client: Use slightly stronger types for NvueConfig#2257
Open
DrewBloechl wants to merge 4 commits into
Open
nvue-client: Use slightly stronger types for NvueConfig#2257DrewBloechl wants to merge 4 commits into
DrewBloechl wants to merge 4 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this, we treated everything inside an
NvueConfigasserde_json::Valuewithout caring about its structure. This branch changes a few things about this:vrf,router,bridge, etc.) toNvueConfig. Below this the types are stillValues but it should reject a lot more obviously-invalid configurations.NvueConfigandNvueConfigWithHeader.NvueConfigis what the API wants us to send it when applying a new configuration, but it generally responds withNvueConfigWithHeaderfrom its config-related endpoints. The startup YAML file is also aNvueConfigWithHeader.Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes