fix(sku): reject empty SKU ID on create and replace#2253
Open
wminckler wants to merge 1 commit into
Open
Conversation
A SKU could be created with an empty id (the proto id field defaults to "" when omitted, and nothing validated it), which Postgres accepts as a valid primary key. Duplicate-content detection would then match that row and report "Specified SKU matches SKU with ID: " with an empty id. Reject empty ids in db::sku::create and db::sku::replace so the empty-id row can never be inserted, and replace fails fast with a clear message instead of a cryptic RowNotFound. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A SKU could be created with an empty id (the proto id field defaults to "" when omitted, and nothing validated it), which Postgres accepts as a valid primary key. Duplicate-content detection would then match that row and report "Specified SKU matches SKU with ID: " with an empty id.
Reject empty ids in db::sku::create and db::sku::replace so the empty-id row can never be inserted, and replace fails fast with a clear message instead of a cryptic RowNotFound.
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes