fix: fallback to lenovo fw config for lenovo-ami machines#2235
Open
krish-nvidia wants to merge 1 commit into
Open
fix: fallback to lenovo fw config for lenovo-ami machines#2235krish-nvidia wants to merge 1 commit into
krish-nvidia wants to merge 1 commit into
Conversation
Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
williampnvidia
approved these changes
Jun 5, 2026
poroh
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
LenovoAMIfirmware config lookup by falling back toLenovofirmware metadata for the same hardware model when noLenovoAMI-specific entry exists.This lets machine update manager find deployed
Lenovofirmware bundles for Lenovo AMI BMC endpoints while preserving exactLenovoAMIconfigs if they are added later. Added regression coverage for fallback behavior and exact-match precedence.Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes