Skip to content

fix: fallback to lenovo fw config for lenovo-ami machines#2235

Open
krish-nvidia wants to merge 1 commit into
NVIDIA:mainfrom
krish-nvidia:lenovo-ami-fw-upgrade-fix
Open

fix: fallback to lenovo fw config for lenovo-ami machines#2235
krish-nvidia wants to merge 1 commit into
NVIDIA:mainfrom
krish-nvidia:lenovo-ami-fw-upgrade-fix

Conversation

@krish-nvidia
Copy link
Copy Markdown
Contributor

Description

This PR fixes LenovoAMI firmware config lookup by falling back to Lenovo firmware metadata for the same hardware model when no LenovoAMI-specific entry exists.

This lets machine update manager find deployed Lenovo firmware bundles for Lenovo AMI BMC endpoints while preserving exact LenovoAMI configs if they are added later. Added regression coverage for fallback behavior and exact-match precedence.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>
@krish-nvidia krish-nvidia self-assigned this Jun 5, 2026
@krish-nvidia krish-nvidia requested a review from a team as a code owner June 5, 2026 15:54
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f74bbfd2-ba8b-49f5-861c-579de3e59075

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants