Skip to content

feat(validate): add custom template input validation (#565)#703

Draft
ArangoGutierrez wants to merge 1 commit intoNVIDIA:mainfrom
ArangoGutierrez:feat/565-custom-template-validation
Draft

feat(validate): add custom template input validation (#565)#703
ArangoGutierrez wants to merge 1 commit intoNVIDIA:mainfrom
ArangoGutierrez:feat/565-custom-template-validation

Conversation

@ArangoGutierrez
Copy link
Collaborator

Summary

Test plan

  • 9 new test cases covering all validation rules
  • All existing validation tests continue to pass
  • go build ./... passes
  • go vet ./... passes

Validates template name, phase, source exclusivity, URL scheme (HTTPS
only), file path safety (including path traversal), checksum format
(sha256), and duplicate names.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22684960905

Details

  • 55 of 59 (93.22%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 48.9%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/provisioner/templates/validate.go 55 59 93.22%
Totals Coverage Status
Change from base Build 22684231249: 0.5%
Covered Lines: 2712
Relevant Lines: 5546

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants