Mark defaultRuntime as optional, remove validation constraints#2162
Merged
tariq1890 merged 1 commit intoNVIDIA:mainfrom Feb 24, 2026
Merged
Mark defaultRuntime as optional, remove validation constraints#2162tariq1890 merged 1 commit intoNVIDIA:mainfrom
tariq1890 merged 1 commit intoNVIDIA:mainfrom
Conversation
empovit
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
empovit
force-pushed
the
fix-required-defaultruntime
branch
from
68efb24 to
a4c2ac8
Compare
empovit
force-pushed
the
fix-required-defaultruntime
branch
from
a4c2ac8 to
f26ef59
Compare
Contributor
|
/ok to test f26ef59 |
Contributor
|
This now becomes a breaking change as the field behavior is changed. We'll need to evaluate if we want to do this or add back the optional field we removed in clusterpolicy json for now. Update: it looks like we were not using this field previously. So any value set was not getting used. Since the field was not used, this change doesn't break any functionality and is not a breaking change then. Its safe to accept this change then. |
tariq1890
approved these changes
Feb 24, 2026
rahulait
approved these changes
Feb 24, 2026
Commit cf964b8 marked `defaultRuntime` as deprecated, removed it from alm-examples in the OpenShift operator. However, the validations on this field remained in the CRD. As a result, trying to create a default `ClusterPolicy` based on alm-examples failed with the following error: ``` spec.operator.defaultRuntime: Unsupported value: "": supported values: "docker", "crio", "containerd" ``` This fixes the issue by making the field optional and removing the validations. Signed-off-by: Vitaliy Emporopulo <vemporop@redhat.com>
empovit
force-pushed
the
fix-required-defaultruntime
branch
from
f26ef59 to
5831d10
Compare
tariq1890
changed the title
cdesiniotis
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit cf964b8 marked
defaultRuntimeas deprecated, removed it from alm-examples in the OpenShift operator. However, the validations on this field remained in the CRD. As a result, trying to create a defaultClusterPolicybased on alm-examples failed with the following error:This fixes the issue by making the field optional and removing the validations.
Description
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
No code changes to affect unit-tests. The fix was tested manually with a custom bundle image.