Support Data Center precompiled driver container for Arm (Ubuntu 24.04)#533
Support Data Center precompiled driver container for Arm (Ubuntu 24.04)#533
Conversation
6405d48 to
574ce43
Compare
20726a8 to
46aa0d1
Compare
c008150 to
b684015
Compare
|
|
||
| - name: Set up Holodeck | ||
| uses: NVIDIA/holodeck@v0.2.18 | ||
| uses: NVIDIA/holodeck@main |
There was a problem hiding this comment.
I will update it and specify the actual version once @ArangoGutierrez releases the new version of Holodeck.
There was a problem hiding this comment.
This will try to install linux-signatures-nvidia-* on arm64 but I see a comment in local-repo.sh where we are intentionally skipping this for arm64 as its not available. Don't we have the same issue here then? Same applies to else block where I also see linux-signature-nvidia-* for closed driver modules.
There was a problem hiding this comment.
Thanks, Rahul.
This should be skipped for arm64.
Also, I need to update the check for
SUPPORTED_KERNELS_LINUX_SIGNATURES_LIST=$(apt-cache search "linux-signatures-nvidia.*${LTS_KERNEL}.*${KERNEL_FLAVOR}" | awk '{print $1}' | sed -e "s/^.*${LTS_KERNEL}/${LTS_KERNEL}/" | sort -n -t'-' -k2| grep "${KERNEL_FLAVOR}$")
in the generate-ci-config file.
There was a problem hiding this comment.
Pull request overview
This pull request adds ARM64 (aarch64) platform support to the Ubuntu 24.04 precompiled driver container builds, while maintaining AMD64 as the default architecture. The changes enable multi-platform Docker builds and update the CI/CD pipeline to handle both architectures.
Changes:
- Added ARM64 platform support for Ubuntu 24.04 precompiled driver containers with architecture-specific package handling
- Updated CI workflow to build, test, and publish both AMD64 and ARM64 artifacts with platform-specific suffixes
- Modified Holodeck test infrastructure to support ARM64 instances (g5g.xlarge in us-west-2) and Ubuntu 24.04 OS specification
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ubuntu24.04/precompiled/nvidia-driver | Added conditional installation of libnvidia-fbc1 package (AMD64 only) |
| ubuntu24.04/precompiled/local-repo.sh | Added conditional downloads for ARM64-incompatible packages (linux-signatures-nvidia, libnvidia-fbc1) |
| ubuntu24.04/precompiled/Dockerfile | Made i386 architecture and CUDA repository URLs conditional based on target architecture |
| tests/scripts/findkernelversion.sh | Added optional PLATFORM_SUFFIX parameter for artifact matching and platform-specific manifest inspection |
| tests/scripts/ci-precompiled-helpers.sh | Added PLATFORM_SUFFIX parameter support for kernel version testing |
| tests/holodeck_ubuntu24.04.yaml | Removed file (merged into holodeck_ubuntu.yaml) |
| tests/holodeck_ubuntu.yaml | Removed hardcoded ingressIpRanges and AMI, added OS specification support |
| multi-arch.mk | Removed AMD64-only platform restriction for ubuntu24.04 builds |
| Makefile | Added DOCKER_BUILD_PLATFORM_OPTIONS to base image build targets |
| .github/workflows/precompiled.yaml | Added platform matrix dimension, platform-aware artifact naming, ARM64 e2e testing with appropriate instance types, and Holodeck version update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Set up Holodeck | ||
| uses: NVIDIA/holodeck@v0.2.18 | ||
| uses: NVIDIA/holodeck@main |
There was a problem hiding this comment.
The Holodeck version has been changed from a pinned version (v0.2.18) to @main, which is not a best practice for CI/CD workflows. Using @main introduces unpredictability as the main branch could contain breaking changes at any time. The other workflow file (.github/workflows/ci.yaml) uses NVIDIA/holodeck@v0.2.18. Consider using a specific pinned version or tag instead of @main for stability and reproducibility.
| uses: NVIDIA/holodeck@main | |
| uses: NVIDIA/holodeck@v0.2.18 |
ef13c9b to
ee1265d
Compare
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
ee1265d to
49429dd
Compare
Code Changes Summary:
Platform Support
Added support for the ARM64 platform.
AMD64 remains the default architecture.
Artifacts Update
ARM64 build artifacts are now uploaded with the -arm64 suffix.
Holodeck Version Compatibility Updates (ARM64 Supported)
ingressIpRanges is no longer required in the Holodeck YAML file and has been removed.
AMI specification is no longer mandatory and has been removed.
OS distribution can now be specified directly (e.g., ubuntu22.04 or ubuntu24.04).
Merged ubuntu_22.04.yaml and ubuntu24.04.yaml into a single configuration due to this update.
Instance Type and Region Mapping
g4dn.xlarge:
Architecture: AMD64
Supported Region: us-west-1
Used for AMD64 builds.
g5g.xlarge:
Architecture: ARM64
Supported Region: us-west-2
Used for ARM64 builds.
passed pipeline: https://github.com/NVIDIA/gpu-driver-container/actions/runs/22180871853