Skip to content

Remove unused extend code in cagra #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aamijar wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −36
Open

Remove unused extend code in cagra #2436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions cpp/src/neighbors/cagra.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,42 +475,6 @@ void extend(raft::resources const& handle,
extend_core<T, IdxT, DatasetViewT>(handle, index, params, extended_dataset, new_start_row);
}

template <class T, class IdxT, cuvs::neighbors::ann_dataset_view DatasetViewT>
void extend(raft::resources const& handle,
const cagra::extend_params& params,
cuvs::neighbors::device_standard_dataset_view<T, int64_t> extended_dataset,
int64_t new_start_row,
cuvs::neighbors::cagra::index<T, IdxT, DatasetViewT>& index)
{
RAFT_FAIL(
"cagra::extend requires a padded extended dataset view. "
"Concatenate the original and additional vectors into a padded dataset and pass that view.");
}

template <class T, class IdxT, cuvs::neighbors::ann_dataset_view DatasetViewT>
void extend(raft::resources const& handle,
const cagra::extend_params& params,
cuvs::neighbors::host_padded_dataset_view<T, int64_t> extended_dataset,
int64_t new_start_row,
cuvs::neighbors::cagra::index<T, IdxT, DatasetViewT>& index)
{
RAFT_FAIL(
"cagra::extend requires a device-padded extended dataset view. "
"Concatenate on the device (or copy the concatenated host matrix to device) before extend.");
}

template <class T, class IdxT, cuvs::neighbors::ann_dataset_view DatasetViewT>
void extend(raft::resources const& handle,
const cagra::extend_params& params,
cuvs::neighbors::host_standard_dataset_view<T, int64_t> extended_dataset,
int64_t new_start_row,
cuvs::neighbors::cagra::index<T, IdxT, DatasetViewT>& index)
{
RAFT_FAIL(
"cagra::extend requires a device-padded extended dataset view. "
"Concatenate the original and additional vectors into a padded device dataset first.");
}

template <class T, class IdxT, cuvs::neighbors::ann_dataset_view DatasetViewT>
cuvs::neighbors::cagra::index<T, IdxT, DatasetViewT> merge(
raft::resources const& handle,
Expand Down
Loading