Enable security scanning via NVIDIA/security-workflows suite #2430
+53
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,46 @@ | ||||||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||||||
| # SPDX-License-Identifier: Apache-2.0 | ||||||
| # | ||||||
| # CI security scanning via the NVIDIA/security-workflows suite: Pulse secret scan + CodeQL SAST. | ||||||
| # Pulse runs on Linux nv-gha-runners. | ||||||
| # Pinned to security-workflows v0.3.0. | ||||||
|
|
||||||
|
Comment on lines
+5
to
+7
Member
There was a problem hiding this comment.
Suggested change
Let's please remove these comments that don't add information (they are obvious from the code) and are likely to become out of date as this configuration changes over time. |
||||||
| name: security suite | ||||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| branches: | ||||||
| - "main" | ||||||
| - "release/*" | ||||||
| - "pull-request/[0-9]+" | ||||||
| workflow_dispatch: | ||||||
|
|
||||||
| concurrency: | ||||||
| group: ${{ github.workflow }}-${{ github.ref }} | ||||||
| cancel-in-progress: true | ||||||
|
|
||||||
| permissions: {} | ||||||
|
|
||||||
| jobs: | ||||||
| security-suite: | ||||||
| # Pulse needs nv-gha-runners + Vault/nvcr vars; skip on forks. | ||||||
| if: github.repository == 'NVIDIA/cuvs' | ||||||
| # The caller must grant every permission the reusable workflow declares, including | ||||||
| # scans this repo does not enable — GitHub validates the grant before evaluating | ||||||
| # each scan's condition. | ||||||
| permissions: | ||||||
| actions: read | ||||||
| contents: read | ||||||
| id-token: write # OIDC -> Vault -> nvcr.io image pull | ||||||
| security-events: write # publish redacted SARIF to code scanning | ||||||
| uses: NVIDIA/security-workflows/.github/workflows/security-suite.yml@711025b090f2aa728da576700750b195d1e816dc # v0.3.0 | ||||||
| with: | ||||||
| enable-secret-scan: true | ||||||
| enable-sast-scan: true | ||||||
| secret-runs-on: linux-amd64-cpu4 | ||||||
| # Set the policy explicitly so enforcement can't drift with upstream defaults. | ||||||
| # unverified — fail on verified/live secrets; warn on unverified [default] | ||||||
| # strict — fail on any finding (verified or unverified) | ||||||
| # all — warn only; never fail the job on findings | ||||||
| secret-failure-policy: unverified | ||||||
| sast-languages: '["python","actions"]' | ||||||
|
Member
There was a problem hiding this comment.
Suggested change
Let's alphabetize this, please. Also, I couldn't find documentation on the available options for this at https://github.com/NVIDIA/security-workflows ... are there more? This repo has Bash, C++, Go, Java, and Rust code too. |
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this file to all the
changed-fileslists in https://github.com/NVIDIA/cuvs/blob/main/.github/workflows/pr.yaml (preserve alphabetical order).We shouldn't need to trigger cuVS's expensive GPU-using CI on PRs that only change this file.