Fix dtype validation for conditional SM targets - #106
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #105.
Strip one recognized architecture or family suffix before converting the SM number in
check_dtype_support. Keep the original target string for diagnostics and leave tileiras target selection unchanged.The new compiler tests export bytecode without requiring device arguments. They cover plain and suffixed targets, dtype and bytecode version limits, and malformed suffixes.
Validation
PYTHONPATH=src python -m pytest --noconftest -o addopts="" test/test_conditional_arch.py test/test_ir_types.py test/test_ast_util.py test/test_float_encoding.py -q: 32 passed.python -m flake8 src/cuda/tile/_passes/check_dtype_support.py test/test_conditional_arch.py: passed.git diff --check: passed.Tests ran in Linux arm64 with the working-tree Python sources and the cuda-tile 1.6.0 wheel's native extension. GPU fixtures, kernel execution, and a source build of the extension were not run. This fixes the Python validation failure only; the separate tileiras target-support limitation described in the issue remains unchanged.
Checklist