refactor(tests): link internal tests against cuopt_static by ramakrishnap-nv · Pull Request #1581 · NVIDIA/cuopt

ramakrishnap-nv · 2026-07-16T15:40:41Z

Summary

Prerequisite structural work for enabling -fvisibility=hidden on libcuopt.so (issue #1213). An earlier attempt using CUOPT_INTERNAL_EXPORT annotations (PR #1574) was closed after the scope of symbols to annotate proved too large (including static data members that cannot carry visibility attributes).

This PR puts the test infrastructure in place so that hidden visibility can be enabled in a follow-up.

cuopt_objs OBJECT library — compile sources once; both cuopt (shared) and cuopt_static (static, BUILD_TESTS only) consume the same object files
STATIC_LIB option in ConfigureTest — links cuopt_static and omits cuopttestutils (which transitively pulls in the shared lib) for tests that need compiled internal symbols
ROUTING_INTERNAL_TEST — new target consolidating GES solver, cross-route insertion, local-search candidate, and top-k tests; also registers four previously unbuilt files (l0_scross_test.cu, local_search_cand_test.cu, load_balancing_test.cu, feasibility_jump_tests.cu)
gRPC tests — GRPC_CLIENT_TEST and GRPC_INTEGRATION_TEST now compile the gRPC client/mapper sources directly into the test binary, following the pattern already used by GRPC_PIPE_SERIALIZATION_TEST; no internal symbols need exporting from the shared lib
cuOptIsCusparseRuntimeMixedPrecisionSupported() — promoted from an internal function to the public C API; c_api_tests.cpp updated to call the public version

Prerequisite structural work for enabling -fvisibility=hidden on libcuopt.so (issue #1213). - Introduce cuopt_objs OBJECT library so cuopt (shared) and cuopt_static (static, BUILD_TESTS only) share one compile step - Add STATIC_LIB option to ConfigureTest; when set, links cuopt_static and omits cuopttestutils to avoid transitive cuopt-shared pull-in - Route all tests with compiled internal symbol dependencies through STATIC_LIB: DUAL_SIMPLEX_TEST, LP_INTERNAL_TEST, PDLP_TEST, MPS_PARSER_TEST, most MIP tests, SOCP_TEST, ROUTING_INTERNAL_TEST - Create ROUTING_INTERNAL_TEST consolidating GES, scross, local-search candidate, and top-k tests; register previously unbuilt test files (l0_scross_test.cu, local_search_cand_test.cu, load_balancing_test.cu, feasibility_jump_tests.cu) - Add gRPC source files directly to GRPC_CLIENT_TEST and GRPC_INTEGRATION_TEST so they do not depend on internal symbols being exported from the shared library - Promote is_cusparse_runtime_mixed_precision_supported() to the public C API as cuOptIsCusparseRuntimeMixedPrecisionSupported(); update c_api_tests.cpp to use the public function Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

copy-pr-bot · 2026-07-16T15:40:45Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Collapse 19 separate STATIC_LIB test binaries (dual_simplex, LP internal, PDLP, MPS parser, 11 MIP, SOCP) into a single NUMOPT_INTERNAL_TEST binary linked against cuopt_static. Routing internal tests remain in ROUTING_INTERNAL_TEST. This reduces total static-linked binary count from 19 to 2, cutting link time and disk usage. Also fix cuopt_c.cpp to forward-declare is_cusparse_runtime_mixed_precision_supported() instead of including cusparse_view.hpp, which pulled CUDA intrinsics into a CXX translation unit. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

Fix four issues discovered when building NUMOPT_INTERNAL_TEST and ROUTING_INTERNAL_TEST: - omp_helpers.hpp: closing namespace brace was outside #ifdef _OPENMP, causing "expected a declaration" when compiled without -fopenmp. - cuopt_static: propagate OpenMP::OpenMP_CXX PUBLIC and -fopenmp for CUDA TUs so test binaries that link cuopt_static compile OMP-heavy internal headers correctly. - cuopt shared: restore CUSPARSE_ENABLE_EXPERIMENTAL_API and CUOPT_LOG_ACTIVE_LEVEL as PUBLIC compile definitions; they were lost when compile definitions moved from cuopt to cuopt_objs (the $<TARGET_OBJECTS:...> pattern does not carry INTERFACE properties). - Combined binaries: add CUOPT_DISABLE_TEST_MAIN guard to CUOPT_TEST_PROGRAM_MAIN() in base_fixture.hpp; provide a single main.cu entry point per binary; make init_handler static in three MIP test files to resolve ODR violations; compile check_constraints.cu directly into ROUTING_INTERNAL_TEST for check_route; add missing src/ and src/io/ include paths to GRPC_CLIENT_TEST and GRPC_INTEGRATION_TEST. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

coderabbitai · 2026-07-16T19:55:14Z

📝 Walkthrough

Walkthrough

The PR refactors CUOPT’s CMake targets around shared object files, adds a public cuSPARSE mixed-precision capability API, and consolidates internal tests with shared entry points and static-library linking.

Changes

CUOPT build and test refactor

Layer / File(s)	Summary
Object-based library targets `cpp/CMakeLists.txt`, `cpp/src/utilities/omp_helpers.hpp`	Core sources are compiled by `cuopt_objs` and reused to create `cuopt_static` and the shared `cuopt` library, with dependency and interface wiring updated.
cuSPARSE capability API `cpp/include/cuopt/mathematical_optimization/cuopt_c.h`, `cpp/src/pdlp/cuopt_c.cpp`, `cpp/tests/linear_programming/c_api_tests/c_api_tests.cpp`	Adds `cuOptIsCusparseRuntimeMixedPrecisionSupported()` and updates the C API test to call it.
Shared test linking and entry points `cpp/tests/CMakeLists.txt`, `cpp/tests/internal/*`, `cpp/tests/utilities/base_fixture.hpp`	`ConfigureTest` supports static-library linking, internal tests share one executable entry point, and per-file test mains can be disabled.
Internal and integration test targets `cpp/tests/{linear_programming,mip,routing,socp}/CMakeLists.txt`, `cpp/tests/linear_programming/grpc/CMakeLists.txt`, `cpp/tests/mip/*_test.cu`	Test registrations and source lists are reorganized, gRPC tests include additional implementation sources, and selected MIP helpers use internal linkage.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

NVIDIA/cuopt#1574: Refactors overlapping C++ test link configuration and internal symbol visibility.

Suggested reviewers: tmckayus, hlinsen, yuwenchen95

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately reflects the main build refactor of linking internal tests against cuopt_static.
Description check	✅ Passed	The description is clearly related to the changeset and summarizes the major build and test infrastructure updates.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch refactor/test-static-link-for-internal-tests

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-16T19:55:27Z

CI Test Summary

8 failed · 23 passed · 0 skipped

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cpp/CMakeLists.txt`:
- Around line 639-677: Update target_link_libraries for the shared cuopt target
to link PSLP directly, matching the existing cuopt_static linkage by reusing
$<TARGET_FILE:PSLP>. Place it with the other required PUBLIC dependencies so
third_party_presolve.cpp symbols resolve when building cuopt.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ca9f970f-6e82-46b2-bac4-a965fe3f4b2a

📥 Commits

Reviewing files that changed from the base of the PR and between d66bf29 and 349b12a.

📒 Files selected for processing (18)

cpp/CMakeLists.txt
cpp/include/cuopt/mathematical_optimization/cuopt_c.h
cpp/src/pdlp/cuopt_c.cpp
cpp/src/utilities/omp_helpers.hpp
cpp/tests/CMakeLists.txt
cpp/tests/dual_simplex/CMakeLists.txt
cpp/tests/internal/CMakeLists.txt
cpp/tests/internal/main.cu
cpp/tests/linear_programming/CMakeLists.txt
cpp/tests/linear_programming/c_api_tests/c_api_tests.cpp
cpp/tests/linear_programming/grpc/CMakeLists.txt
cpp/tests/mip/CMakeLists.txt
cpp/tests/mip/bounds_standardization_test.cu
cpp/tests/mip/elim_var_remap_test.cu
cpp/tests/mip/multi_probe_test.cu
cpp/tests/routing/CMakeLists.txt
cpp/tests/socp/CMakeLists.txt
cpp/tests/utilities/base_fixture.hpp

💤 Files with no reviewable changes (3)

cpp/tests/dual_simplex/CMakeLists.txt
cpp/tests/linear_programming/CMakeLists.txt
cpp/tests/socp/CMakeLists.txt

All tests from these directories moved to NUMOPT_INTERNAL_TEST. The subdirectories and add_subdirectory calls serve no purpose now. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

$<TARGET_OBJECTS:cuopt_objs> does not propagate PRIVATE link dependencies to consuming targets; PSLP must be linked explicitly on both cuopt_static and cuopt (shared). Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

mlubin · 2026-07-16T21:41:05Z

 * the command line to customize test behavior, like the allocation mode used
 * for creating the default memory resource.
+ *
+ * When CUOPT_DISABLE_TEST_MAIN is defined (e.g. when compiling multiple test


Do we need this macro? What about deleting CUOPT_TEST_PROGRAM_MAIN in the test files that no longer need a main?

…test files Files compiled into NUMOPT_INTERNAL_TEST and ROUTING_INTERNAL_TEST no longer need their own main(); remove the call directly rather than suppressing it via the CUOPT_DISABLE_TEST_MAIN guard. Simplifies base_fixture.hpp and the CMakeLists files. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

ramakrishnap-nv added 2 commits July 16, 2026 11:20

ramakrishnap-nv added this to the 26.08 milestone Jul 16, 2026

ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 16, 2026

ramakrishnap-nv marked this pull request as ready for review July 16, 2026 19:53

ramakrishnap-nv requested review from a team as code owners July 16, 2026 19:53

ramakrishnap-nv requested review from hlinsen, tmckayus and yuwenchen95 July 16, 2026 19:53

style(tests): remove stale comments from empty CMakeLists stubs

349b12a

Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

coderabbitai Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread cpp/CMakeLists.txt

ramakrishnap-nv added 2 commits July 16, 2026 15:07

refactor(tests): remove empty dual_simplex and socp CMakeLists stubs

3dcd5d6

All tests from these directories moved to NUMOPT_INTERNAL_TEST. The subdirectories and add_subdirectory calls serve no purpose now. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

fix(build): link PSLP directly on cuopt shared target

921078b

$<TARGET_OBJECTS:cuopt_objs> does not propagate PRIVATE link dependencies to consuming targets; PSLP must be linked explicitly on both cuopt_static and cuopt (shared). Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>

ramakrishnap-nv mentioned this pull request Jul 16, 2026

[DRAFT] Minimize cuopt_static test linkage to avoid 5 GB package size explosion #1566

Closed

3 tasks

mlubin reviewed Jul 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(tests): link internal tests against cuopt_static#1581

refactor(tests): link internal tests against cuopt_static#1581
ramakrishnap-nv wants to merge 7 commits into
mainfrom
refactor/test-static-link-for-internal-tests

ramakrishnap-nv commented Jul 16, 2026 •

edited

Loading

Uh oh!

copy-pr-bot Bot commented Jul 16, 2026

Uh oh!

coderabbitai Bot commented Jul 16, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

mlubin Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ramakrishnap-nv commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

copy-pr-bot Bot commented Jul 16, 2026

Uh oh!

coderabbitai Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Test Summary

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mlubin Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ramakrishnap-nv commented Jul 16, 2026 •

edited

Loading

coderabbitai Bot commented Jul 16, 2026 •

edited

Loading

github-actions Bot commented Jul 16, 2026 •

edited

Loading