ci: enable codecov for Python test coverage#1575
Open
ramakrishnap-nv wants to merge 5 commits into
Open
Conversation
Removes the explicit `run_codecov: false` override in pr.yaml and test.yaml, restoring the shared-workflow default (true). Adds codecov.yml at repo root with patch checks set to informational so coverage never blocks a PR. Adds disable_warnings to .coveragerc to suppress spurious coverage.py noise. Excludes codecov.yml from changed-files triggers so a config-only edit does not re-run CI. Note: requires CODECOV_TOKEN to be set as a repo or org secret. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
ramakrishnap-nv
added
non-breaking
📝 WalkthroughWalkthroughChangesCodecov CI integration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CI Test Summary2 failed · 29 passed · 0 skipped |
Collaborator
Author
|
/ok to test 003e569 |
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Switch conda-python-tests in pr.yaml to secrets: inherit so CODECOV_TOKEN reaches the shared-workflow codecov step. S3/AWS secrets are not needed for PR builds (nightly_report_helper skips S3 when RAPIDS_BUILD_TYPE!=nightly). Re-add run_codecov: false to test.yaml conda-python-tests since S3 explicit secrets are required there for nightly report aggregation, leaving no slot for CODECOV_TOKEN until rapidsai/shared-workflows#<TBD> lands. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Use the same key/value pattern as S3/AWS secrets to pass CODECOV_TOKEN to the conda-python-tests shared workflow. Requires rapidsai/shared-workflows#593. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
This reverts commit c06c38f. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the explicit
run_codecov: falseoverride, addscodecov.yml(patch checks informational, never blocks), suppresses spurious coverage.py warnings, and excludescodecov.ymlfrom changed-files triggers.Requires
CODECOV_TOKENto be set as a repo/org secret.