Skip to content

Fix sdist tests in CI#2241

Merged
mdboom merged 2 commits into
NVIDIA:mainfrom
mdboom:fix-sdist-tests
Jun 22, 2026
Merged

Fix sdist tests in CI#2241
mdboom merged 2 commits into
NVIDIA:mainfrom
mdboom:fix-sdist-tests

Conversation

@mdboom

@mdboom mdboom commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

setuptools-scm 10.1.1 broke our sdist builds.

This appears to be a known issue that at least xarray is also running into: pypa/setuptools-scm#1423

This places an upper bound on setuptools-scm and also (necessarily) one of its dependencies to get our CI working again. We can remove these upper bounds when the bug is fixed upstream.

@copy-pr-bot

copy-pr-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom

mdboom commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Jun 22, 2026
@mdboom

mdboom commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

3 similar comments
@mdboom

mdboom commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@mdboom

mdboom commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@mdboom

mdboom commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

@mdboom mdboom force-pushed the fix-sdist-tests branch from 0cf310f to c0f541b Compare June 22, 2026 18:09
@github-actions github-actions Bot added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module labels Jun 22, 2026
@mdboom

mdboom commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@mdboom

mdboom commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@mdboom mdboom marked this pull request as ready for review June 22, 2026 18:20
@mdboom mdboom changed the title Testing what is broken about sdist tests Fix sdist tests in CI Jun 22, 2026
@mdboom mdboom added the P0 High priority - Must do! label Jun 22, 2026
@mdboom mdboom enabled auto-merge (squash) June 22, 2026 19:46
@mdboom mdboom merged commit 9160a82 into NVIDIA:main Jun 22, 2026
108 of 111 checks passed
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants