Use shared_ptr for NVML event_set resource management#2240
Draft
mdboom wants to merge 2 commits into
Draft
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
the
cuda.core
Contributor
Author
|
/ok to test |
mdboom
force-pushed
the
use-shared-ptr-for-event-set
branch
from
b5904e5 to
80b0d60
Compare
Contributor
Author
|
/ok to test |
|
mdboom
force-pushed
the
use-shared-ptr-for-event-set
branch
from
80b0d60 to
a41bf7c
Compare
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept of the proposed instructions in #2234. I asked Claude to use those instructions to port the management of NVML event sets to use shared_ptr. I didn't edit its output in any way. We should review this and point out any mistakes, and then use that to improve the instructions in #2234.