-
Notifications
You must be signed in to change notification settings - Fork 240
Add multi-GPU CI runners (t4 and h100 with 2 GPUs) #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f19d167
Add multi-GPU CI runners (t4 and h100 with 2 GPUs)
Andy-Jost cc13ecf
Remove special_runners, integrate entries into pull-request matrix
Andy-Jost 074a6ca
Fix test to avoid cuRAND dependency
Andy-Jost 3184316
Add notes about GPU_COUNT and column alignment
Andy-Jost 4214c2c
Use CuPy's new RNG to avoid libcurand dependency
Andy-Jost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,8 +88,9 @@ def __cuda_stream__(self): | |
| # Allocate memory on GPU 0 | ||
| # Note: This runs on CuPy's current stream for GPU 0 | ||
| dev0.set_current() | ||
| a = cp.random.random(size, dtype=dtype) | ||
| b = cp.random.random(size, dtype=dtype) | ||
| rng = cp.random.default_rng() | ||
| a = rng.random(size, dtype=dtype) | ||
| b = rng.random(size, dtype=dtype) | ||
|
Comment on lines
-91
to
+93
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep a note on this change for posterity:
|
||
| c = cp.empty_like(a) | ||
| cp_stream0 = dev0.create_stream(StreamAdaptor(cp.cuda.get_current_stream())) | ||
|
|
||
|
|
@@ -103,8 +104,9 @@ def __cuda_stream__(self): | |
| # Allocate memory on GPU 1 | ||
| # Note: This runs on CuPy's current stream for GPU 1. | ||
| dev1.set_current() | ||
| x = cp.random.random(size, dtype=dtype) | ||
| y = cp.random.random(size, dtype=dtype) | ||
| rng = cp.random.default_rng() | ||
| x = rng.random(size, dtype=dtype) | ||
| y = rng.random(size, dtype=dtype) | ||
| z = cp.empty_like(a) | ||
| cp_stream1 = dev1.create_stream(StreamAdaptor(cp.cuda.get_current_stream())) | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only nitpick is that it'd be nice to have a comment or code block that separates out "special runners" (including the 2-GPU ones introduced in this PR) from the regular matrix. It's easier to eyeball and update.