Remove context dependency from __hash__ and __eq__ #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify Stream and Event hash/equality to use pointer comparison only, avoiding expensive context lookups. This follows the cccl-rt principle and fixes issues with wrapping foreign streams where context is unknown. Closes NVIDIA#1480
Contributor
Andy-Jost
added
enhancement
Contributor
Author
|
/ok to test c8e9bc7 |
Contributor
Author
|
The associated issue only mentions streams, but I applied the same fix to events as well. |
This comment has been minimized.
This comment has been minimized.
kkraus14
approved these changes
Jan 15, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stream.__hash__andStream.__eq__to use pointer comparison only, removing expensiveStream_ensure_ctxcallsEvent.__hash__to be consistent withEvent.__eq__by removing context from hashChanges
_stream.pyx: RemoveStream_ensure_ctxcalls and context comparison from__hash__and__eq___event.pyx: Remove_h_contextfrom__hash__(was inconsistent with__eq__which only compares event handle)Motivation
As reported in #1480, requiring CUDA context for hash/equality is problematic because:
This follows the cccl-rt principle of simple pointer comparison.
Closes #1480