Skip to content

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Jan 15, 2026

Found by SWQA on hardware that isn't in our CI.

@mdboom mdboom requested review from rparolin and rwgk January 15, 2026 14:20
@mdboom mdboom self-assigned this Jan 15, 2026
@mdboom mdboom added test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Jan 15, 2026
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 15, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom
Copy link
Contributor Author

mdboom commented Jan 15, 2026

Note, this doesn't need a backport -- it's cuda.core-only.

@mdboom mdboom force-pushed the cuda.core.system-skip-test branch from 493e83b to cc21322 Compare January 15, 2026 14:23
@mdboom
Copy link
Contributor Author

mdboom commented Jan 15, 2026

/ok to test

@github-actions

This comment has been minimized.

@kkraus14 kkraus14 merged commit 8725e96 into NVIDIA:main Jan 15, 2026
80 checks passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@rwgk
Copy link
Collaborator

rwgk commented Jan 15, 2026

I'm concerned about the skip_reasons getting lost when something goes wrong in any of the iterations over the loop. I think we should fix that in a follow-on PR.

@mdboom
Copy link
Contributor Author

mdboom commented Jan 15, 2026

I'm concerned about the skip_reasons getting lost when something goes wrong in any of the iterations over the loop. I think we should fix that in a follow-on PR.

Yes, though having multiple devices is extremely rare. I'm starting to come around that keeping track of multiple skip reasons isn't worth the effort, and it's fine to just stop at the first occurrence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module test Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants