[libcu++] Change inplace_vector return type for try_meow methods#9130
[libcu++] Change inplace_vector return type for try_meow methods#9130davebayer wants to merge 1 commit into
inplace_vector return type for try_meow methods#9130Conversation
| #include <cuda/std/__memory/uninitialized_algorithms.h> | ||
| #include <cuda/std/__new/device_new.h> | ||
| #include <cuda/std/__new/launder.h> | ||
| #include <cuda/std/__optional/optional_ref.h> |
There was a problem hiding this comment.
@miscco should I only include this header or rather full <cuda/std/optional>?
643ec6f to
bc683a6
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR changes ChangesTry_ API contract change*
Comment |
🥳 CI Workflow Results🟩 Finished in 3h 15m: Pass: 100%/116 | Total: 5d 05h | Max: 3h 14m | Hits: 39%/2072236See results here. |
This PR implements part of P3981R2 that changes
inplace_vectorreturn types fortry_meowmethods.I've not updated the feature testing macro value, because there is another paper that we don't currently implement and they share the same macro value.
This is a source breaking change, but it's consistent what other standard libraries do when a feature is changed before the standard release.