[cudax] Implement more CUDA graphs APIs#8271
Open
pciolkosz wants to merge 4 commits intoNVIDIA:mainfrom
Open
Conversation
This comment has been minimized.
This comment has been minimized.
caugonnet
reviewed
Apr 2, 2026
| cudax::launch(pb, test::one_thread_dims, test::verify_n<43>{}, ptr); | ||
|
|
||
| auto exec = g.instantiate(); | ||
| exec.launch(s); |
Contributor
There was a problem hiding this comment.
You should have a test that verifies we can create a host callback like this and launch it multiple time (to ensure we properly destroy argument payload)
Contributor
Author
There was a problem hiding this comment.
Thanks! I added a test case like that
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 27m: Pass: 100%/137 | Total: 1d 03h | Max: 56m 27s | Hits: 98%/282056See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR throws away all graph node insertion APIs and instead adds __graphAddNode. The polymorphic cuGraphAddNode is the recommended way to add graph nodes and other APIs will get deprecated in the future.
It also adds a few new APIs: