Repository navigation
Conversation
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
The more_cutedsl_mxfp8_specialized base was squash-merged as NVIDIA#3642, so CuTeDSL conflicts were resolved by 3-way merging against bfdb240. - quantize_mxfp8_common.py: keep the preferred_kernels restructure and carry over main's removal of "cast-only" from the comment. - quantize_mxfp8_cutedsl.cuh: drop the 2D-unsupported guard that main had only edited, since 2D quantization is now implemented in CuTeDSL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
for more information, see https://pre-commit.ci
Contributor
[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issues were found. SummaryAdds CuTeDSL MXFP8 quantization with one shared scale per 32×32 block.
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MXFP8 cast request] --> B{2D scaling requested?}
B -->|Yes| C[2D tile math in general pipeline]
B -->|No| D[Existing kernel selection]
C --> E[FP8 values and repeated block scales]
D --> F[FP8 values and directional scales]
Reviews (2) · Last reviewed commit: "[pre-commit.ci] auto fixes from pre-comm..." · Reviewed by Greptile |
for more information, see https://pre-commit.ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add MXFP8 2D quantization CuTeDSL kernels
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: