[Common] Reduce default cfg's SMEM usage for mhc triton kernel - #3442
Open
kainzhong wants to merge 1 commit into
Open
[Common] Reduce default cfg's SMEM usage for mhc triton kernel#3442kainzhong wants to merge 1 commit into
kainzhong wants to merge 1 commit into
Conversation
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Contributor
Greptile SummaryThis PR reduces shared-memory usage in the MHC Triton projection kernel by adding a two-stage configuration.
Confidence Score: 5/5The PR appears safe to merge, with the lower-stage configuration covered by the existing MHC correctness-test path. The change only adjusts the Triton pipeline-depth candidates, and the forced default configuration is exercised across representative MHC projection shapes and data types without violating any identified kernel constraint. Important Files Changed
Reviews (1): Last reviewed commit: "[Common] Reduce default cfg's SMEM usage..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Somehow with triton 3.8 it allocates more SMEM for my triton kernels than previous triton 3.6, which causes the mhc tests to fail due to OOM. Add stage=2 to reduce the default config's SMEM usage and let the CI pass for now
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: