Skip to content

Conversation

@jenchen13
Copy link
Contributor

What does this PR do?

Type of change: ? Bug fix

Fix hf_quant_config with correct kv cache type for FP8

Overview: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

will test export with KV cache fp8 enabled

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

Signed-off-by: jenchen13 <jennifchen@nvidia.com>
@jenchen13 jenchen13 requested a review from a team as a code owner November 14, 2025 03:24
@jenchen13 jenchen13 requested a review from meenchen November 14, 2025 03:25
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jenchen13 jenchen13 requested a review from ChenhanYu November 14, 2025 03:25
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.37%. Comparing base (a113bea) to head (247bc54).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   74.37%   74.37%           
=======================================
  Files         182      182           
  Lines       18219    18219           
=======================================
  Hits        13550    13550           
  Misses       4669     4669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kv_cache_quantization = None
if get_kv_cache_dtype(self.model) == KV_CACHE_FP8:
# Only FP8 KV Cache is supported in VLLM for now
kv_cache_quantization = "FP8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add FP4 KV support? TRT-LLM actually supports FP4 kv now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added

Signed-off-by: jenchen13 <jennifchen@nvidia.com>
Signed-off-by: Jennifer Chen <jennifchen@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants