Skip to content

Conversation

@reasonsolo
Copy link
Collaborator

@reasonsolo reasonsolo commented Nov 7, 2025

Summary by CodeRabbit

  • Chores

    • Updated dependencies.
  • Tests

    • Modified test coverage to include additional model configurations and accuracy assessments.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@reasonsolo reasonsolo requested a review from a team as a code owner November 7, 2025 05:41
@reasonsolo reasonsolo requested a review from EmmaQiaoCh November 7, 2025 05:41
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

📝 Walkthrough

Walkthrough

This PR updates the DeepGEMM submodule to a newer commit and modifies the integration test waiver list by removing one test entry and adding three new entries for FP8 and DeepSeek configurations.

Changes

Cohort / File(s) Summary
Submodule Update
3rdparty/DeepGEMM
Updated submodule pointer to commit 9fa5965e265e27995f539e0dd73a06351a8a9eaf
Test Waiver Modifications
tests/integration/test_lists/waives.txt
Removed one test entry for disaggregated spec decoding; added three new test entries for FP8 configurations (Minitron 4B, CLI flow, DeepSeek V3 Lite)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Submodule pointer updates are straightforward reference changes requiring minimal verification
  • Test waiver list modifications are configuration changes that should be validated for correct test identifiers

Possibly related PRs

Suggested reviewers

  • EmmaQiaoCh
  • pcastonguay
  • chzblych

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete. The critical sections (title, Description, and Test Coverage) contain only template placeholders with no actual content filled in. Provide a proper PR title following the template format (e.g., [https://nvbugs/5608743][chore] unwaive test), fill in the Description section explaining what changes were made and why, and specify the Test Coverage section listing relevant tests.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: unwaiving a test. It follows the required format with ticket ID and type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@reasonsolo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23813 [ run ] triggered by Bot. Commit: 4fbae44

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23813 [ run ] completed with state SUCCESS. Commit: 4fbae44
/LLM/release-1.1/L0_MergeRequest_PR pipeline #448 completed with status: 'SUCCESS'

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@reasonsolo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23936 [ run ] triggered by Bot. Commit: 2e5daf3

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23936 [ run ] completed with state SUCCESS. Commit: 2e5daf3
/LLM/release-1.1/L0_MergeRequest_PR pipeline #458 completed with status: 'FAILURE'

@reasonsolo
Copy link
Collaborator Author

/bot run

@reasonsolo reasonsolo enabled auto-merge (squash) November 10, 2025 04:51
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23956 [ run ] triggered by Bot. Commit: 5560893

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23956 [ run ] completed with state SUCCESS. Commit: 5560893
/LLM/release-1.1/L0_MergeRequest_PR pipeline #463 completed with status: 'FAILURE'

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@reasonsolo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24017 [ run ] triggered by Bot. Commit: 3f3b46d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24017 [ run ] completed with state SUCCESS. Commit: 3f3b46d
/LLM/release-1.1/L0_MergeRequest_PR pipeline #464 completed with status: 'SUCCESS'

@reasonsolo reasonsolo merged commit 0649b77 into NVIDIA:release/1.1 Nov 10, 2025
5 checks passed
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 20, 2025
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 20, 2025
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants